build: Add codecov bundle analysis for npm packages #11276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given our bundling setup is a little more complicated, this patch adds codecov bundle analysis for our npm builds (ESM and CJS). It generates the bundle name from the package.json
AbhiPrasad
requested review from
lforst and
Lms24
and removed request for
a team
size-limit report 📦
|
|
This works! although is a little jank. Let's get it merged in so that we can collect results from |
lforst
approved these changes
Mar 26, 2024
| @@ -26,7 +26,7 @@ | |||
| "yaml": "2.2.2" | |||
| }, | |||
| "volta": { | |||
| "node": "18.17.1", | |||
There was a problem hiding this comment.
Codecov plugins require min Node version of 18.18.0.
|
Do you have a link to where I can see the result of this (as an example)? :) |
I did have a link, but it's stopped showing up :/ https://app.codecov.io/gh/getsentry/sentry-javascript/bundles/abhi-codecov-npm let me dig into why |
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
Given our bundling setup is a little more complicated, this patch adds codecov bundle analysis for our just our npm builds (ESM and CJS). It generates the bundle name from the package.json Previous attempt: getsentry#10682 https://docs.codecov.com/docs/rollup-quick-start https://app.codecov.io/gh/getsentry/sentry-javascript/bundles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given our bundling setup is a little more complicated, this patch adds codecov bundle analysis for our just our npm builds (ESM and CJS). It generates the bundle name from the package.json
Previous attempt: #10682
https://docs.codecov.com/docs/rollup-quick-start
https://app.codecov.io/gh/getsentry/sentry-javascript/bundles