Skip to content

test: Re-enable Remix client-side e2e tests #10290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 14, 2024
Merged

test: Re-enable Remix client-side e2e tests #10290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6e55f7d
fix(tests): Fix flaky Remix e2e tests.
onurtemizkan Jan 19, 2024
7adb4cb
Turn on debug mode.
onurtemizkan Jan 19, 2024
b267d84
Turn off debug mode.
onurtemizkan Jan 22, 2024
ae17485
Delete comment
onurtemizkan Jan 22, 2024
fc18aed
Increase polling timeout to 120 seconds.
onurtemizkan Feb 4, 2024
01f4c0d
Remove unused `entry` in remix test config.
onurtemizkan Feb 12, 2024
cf378a4
Set `qa` as the environment to bypass dynamic sampling.
onurtemizkan Feb 12, 2024
8658d52
Reduce timeout to 90 seconds
Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1042,9 +1042,8 @@ jobs:
'node-express-app',
'create-react-app',
'create-next-app',
# disabling remix e2e tests because of flakes
# 'create-remix-app',
# 'create-remix-app-v2',
'create-remix-app',
'create-remix-app-v2',
'debug-id-sourcemaps',
'nextjs-app-dir',
'nextjs-14',
Expand Down
1 change: 1 addition & 0 deletions dev-packages/e2e-tests/test-applications/create-remix-app-v2/app/entry.client.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import { StrictMode, startTransition, useEffect } from 'react';
import { hydrateRoot } from 'react-dom/client';

Sentry.init({
environment: 'qa', // dynamic sampling bias to keep transactions
dsn: window.ENV.SENTRY_DSN,
integrations: [
new Sentry.BrowserTracing({
Expand Down
1 change: 1 addition & 0 deletions dev-packages/e2e-tests/test-applications/create-remix-app-v2/app/entry.server.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ installGlobals();
const ABORT_DELAY = 5_000;

Sentry.init({
environment: 'qa', // dynamic sampling bias to keep transactions
dsn: process.env.E2E_TEST_DSN,
// Performance Monitoring
tracesSampleRate: 1.0, // Capture 100% of the transactions, reduce in production!
Expand Down
1 change: 0 additions & 1 deletion dev-packages/e2e-tests/test-applications/create-remix-app-v2/remix.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,4 @@ module.exports = {
// serverBuildPath: 'build/index.js',
// publicPath: '/build/',
serverModuleFormat: 'cjs',
entry,
};
6 changes: 2 additions & 4 deletions dev-packages/e2e-tests/test-applications/create-remix-app-v2/tests/behaviour-client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,7 @@ test('Sends a client-side exception to Sentry', async ({ page }) => {
.toBe(200);
});

// Skipping test because of flake
test.skip('Sends a pageload transaction to Sentry', async ({ page }) => {
test('Sends a pageload transaction to Sentry', async ({ page }) => {
await page.goto('/');

const recordedTransactionsHandle = await page.waitForFunction(() => {
Expand Down Expand Up @@ -107,8 +106,7 @@ test.skip('Sends a pageload transaction to Sentry', async ({ page }) => {
expect(hadPageLoadTransaction).toBe(true);
});

// Skipped because of test flake
test.skip('Sends a navigation transaction to Sentry', async ({ page }) => {
test('Sends a navigation transaction to Sentry', async ({ page }) => {
await page.goto('/');

// Give pageload transaction time to finish
Expand Down
1 change: 1 addition & 0 deletions dev-packages/e2e-tests/test-applications/create-remix-app/app/entry.client.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import { StrictMode, startTransition, useEffect } from 'react';
import { hydrateRoot } from 'react-dom/client';

Sentry.init({
environment: 'qa', // dynamic sampling bias to keep transactions
dsn: window.ENV.SENTRY_DSN,
integrations: [
new Sentry.BrowserTracing({
Expand Down
1 change: 1 addition & 0 deletions dev-packages/e2e-tests/test-applications/create-remix-app/app/entry.server.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import { renderToPipeableStream } from 'react-dom/server';
const ABORT_DELAY = 5_000;

Sentry.init({
environment: 'qa', // dynamic sampling bias to keep transactions
dsn: process.env.E2E_TEST_DSN,
// Performance Monitoring
tracesSampleRate: 1.0, // Capture 100% of the transactions, reduce in production!
Expand Down
6 changes: 2 additions & 4 deletions dev-packages/e2e-tests/test-applications/create-remix-app/tests/behaviour-client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ const authToken = process.env.E2E_TEST_AUTH_TOKEN;
const sentryTestOrgSlug = process.env.E2E_TEST_SENTRY_ORG_SLUG;
const sentryTestProject = process.env.E2E_TEST_SENTRY_TEST_PROJECT;

// skipping flaky test
test.skip('Sends a client-side exception to Sentry', async ({ page }) => {
test('Sends a client-side exception to Sentry', async ({ page }) => {
await page.goto('/');

const exceptionButton = page.locator('id=exception-button');
Expand Down Expand Up @@ -48,8 +47,7 @@ test.skip('Sends a client-side exception to Sentry', async ({ page }) => {
.toBe(200);
});

// skipping flaky test
test.skip('Sends a pageload transaction to Sentry', async ({ page }) => {
test('Sends a pageload transaction to Sentry', async ({ page }) => {
await page.goto('/');

const recordedTransactionsHandle = await page.waitForFunction(() => {
Expand Down