-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
test: Re-enable Remix client-side e2e tests #10290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
size-limit report 📦
|
f28f129
to
c25aab0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give it a try!
98eee17
to
a80a1bf
Compare
2d7ec58
to
a6370f9
Compare
Seems like it's still failing - https://github.com/getsentry/sentry-javascript/actions/runs/7873415049/job/21481696210?pr=10290
|
a6370f9
to
9a846ef
Compare
@AbhiPrasad, I think I found it. I have set the environment as Also about the other error you mentioned. That was a mistakenly put |
d2cf77a
to
cf378a4
Compare
Fixes and re-enables flaky Remix E2E tests for v7 branch. Ref: #10290
Update: Added
environment: 'qa'
to Remix e2e tests.Could not find anything that may cause this to fail, I suppose it was slow ingestion.It's still weird that it only happens in Remix client-side tests. (They take slightly longer to finish, so they may be more prone to timeout when there's slow ingestion)Ran CI many times, and they're not timing out anymore as far as I see.