Skip to content

test: Re-enable Remix client-side e2e tests #10290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 14, 2024

Conversation

onurtemizkan
Copy link
Collaborator

@onurtemizkan onurtemizkan commented Jan 22, 2024

Update: Added environment: 'qa' to Remix e2e tests.

Could not find anything that may cause this to fail, I suppose it was slow ingestion.

It's still weird that it only happens in Remix client-side tests. (They take slightly longer to finish, so they may be more prone to timeout when there's slow ingestion)

Ran CI many times, and they're not timing out anymore as far as I see.

@onurtemizkan onurtemizkan changed the title Onur/fix flaky remix e2e tests ref(tests): Re-enable Remix client-side e2e tests. Jan 22, 2024
Copy link
Contributor

github-actions bot commented Jan 23, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.82 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.06 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.98 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.67 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.25 KB (0%)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.15 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.16 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.16 KB (0%)
@sentry/browser - Webpack (gzipped) 22.43 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76.1 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.61 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.58 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.69 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 212.81 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 101.43 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.95 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.82 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.43 KB (0%)
@sentry/react - Webpack (gzipped) 22.45 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 87.09 KB (0%)
@sentry/nextjs Client - Webpack (gzipped) 50.35 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 17.12 KB (0%)

@onurtemizkan onurtemizkan changed the title ref(tests): Re-enable Remix client-side e2e tests. chore(tests): Re-enable Remix client-side e2e tests. Jan 23, 2024
@onurtemizkan onurtemizkan force-pushed the onur/fix-flaky-remix-e2e-tests branch 2 times, most recently from f28f129 to c25aab0 Compare January 24, 2024 12:08
@onurtemizkan onurtemizkan marked this pull request as ready for review January 24, 2024 12:24
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a try!

@onurtemizkan onurtemizkan force-pushed the onur/fix-flaky-remix-e2e-tests branch 6 times, most recently from 98eee17 to a80a1bf Compare February 11, 2024 15:34
@onurtemizkan onurtemizkan force-pushed the onur/fix-flaky-remix-e2e-tests branch 2 times, most recently from 2d7ec58 to a6370f9 Compare February 12, 2024 14:42
@AbhiPrasad
Copy link
Member

Seems like it's still failing - https://github.com/getsentry/sentry-javascript/actions/runs/7873415049/job/21481696210?pr=10290

> @ build /home/runner/work/sentry-javascript/sentry-javascript/dev-packages/e2e-tests/test-applications/create-remix-app-v2
> remix build

 info  building... (NODE_ENV=production)
Error: Error loading Remix config at /home/runner/work/sentry-javascript/sentry-javascript/dev-packages/e2e-tests/test-applications/create-remix-app-v2/remix.config.js
ReferenceError: entry is not defined
    at Object.readConfig (/home/runner/work/sentry-javascript/sentry-javascript/dev-packages/e2e-tests/test-applications/create-remix-app-v2/node_modules/.pnpm/registry.npmjs.org+@remix-run+dev@2.0.0_@remix-run+serve@2.0.0_typescript@5.0.4/node_modules/@remix-run/dev/dist/config.js:72:13)
    at async Object.build (/home/runner/work/sentry-javascript/sentry-javascript/dev-packages/e2e-tests/test-applications/create-remix-app-v2/node_modules/.pnpm/registry.npmjs.org+@remix-run+dev@2.0.0_@remix-run+serve@2.0.0_typescript@5.0.4/node_modules/@remix-run/dev/dist/cli/commands.js:140:18)
    at async Object.run (/home/runner/work/sentry-javascript/sentry-javascript/dev-packages/e2e-tests/test-applications/create-remix-app-v2/node_modules/.pnpm/registry.npmjs.org+@remix-run+dev@2.0.0_@remix-run+serve@2.0.0_typescript@5.0.4/node_modules/@remix-run/dev/dist/cli/run.js:176:7)
 ELIFECYCLE  Command failed with exit code 1.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 1.
##[debug]Finishing: Build E2E app

@onurtemizkan onurtemizkan force-pushed the onur/fix-flaky-remix-e2e-tests branch from a6370f9 to 9a846ef Compare February 12, 2024 15:25
@onurtemizkan
Copy link
Collaborator Author

@AbhiPrasad, I think I found it. I have set the environment as qa to bypass dynamic sampling. Hopefully it resolves that.

Also about the other error you mentioned. That was a mistakenly put entry via another PR, I deleted that.

@onurtemizkan onurtemizkan force-pushed the onur/fix-flaky-remix-e2e-tests branch from d2cf77a to cf378a4 Compare February 12, 2024 20:37
@lforst lforst changed the title chore(tests): Re-enable Remix client-side e2e tests. test: Re-enable Remix client-side e2e tests Feb 14, 2024
@lforst lforst enabled auto-merge (squash) February 14, 2024 10:32
@lforst lforst merged commit b8a8b45 into develop Feb 14, 2024
@lforst lforst deleted the onur/fix-flaky-remix-e2e-tests branch February 14, 2024 10:57
Lms24 pushed a commit that referenced this pull request Feb 27, 2024
Fixes and re-enables flaky Remix E2E tests for v7 branch.
Ref: #10290
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants