Skip to content

Enable PHP 8.0 support #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 19, 2020
Merged

Enable PHP 8.0 support #1102

merged 8 commits into from
Dec 19, 2020

Conversation

jbelien
Copy link
Member

@jbelien jbelien commented Dec 15, 2020 •
edited
Loading

  • Add PHP 8.0 support
  • Remove PHP 7.2 support (end of life)
  • Upgrade PHPUnit

I've kept GitHub Actions quite simple.
Migration to GitHub Actions will be handled in #1101

@jbelien jbelien self-assigned this Dec 15, 2020
@jbelien jbelien linked an issue Dec 15, 2020 that may be closed by this pull request
Support for PHP 8.0 #1093
Closed
@jbelien
Copy link
Member Author

jbelien commented Dec 19, 2020

Travis CI is failing with the following error code:

PHP Fatal error:  strict_types declaration must be the very first statement in the script in /home/travis/build/geocoder-php/Geocoder/vendor/phpunit/phpunit/phpunit on line 2

Since we're moving to GiHub Actions, it's not that big of a deal but I did some research and it's due to the fact that we require() PHPUnit script which we are not supposed to do (see sebastianbergmann/phpunit#4096 (comment)).

@jbelien jbelien marked this pull request as ready for review December 19, 2020 08:27
@jbelien jbelien requested review from atymic and Nyholm December 19, 2020 08:27
@jbelien jbelien mentioned this pull request Dec 19, 2020
Closed
Nyholm
Nyholm approved these changes Dec 19, 2020
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Well done!

@jbelien jbelien merged commit 93939ac into master Dec 19, 2020
@jbelien jbelien deleted the php8 branch December 19, 2020 09:41
@jbelien jbelien mentioned this pull request Dec 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

@atymic atymic Awaiting requested review from atymic

Assignees

@jbelien jbelien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for PHP 8.0
2 participants
@jbelien @Nyholm