Add GitHub Actions #1101
Merged
Add GitHub Actions #1101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've kept it simple for now. I'll try to add |
Merged
|
Still to "fix":
|
GeoIP extensions is not (yet?) available for PHP 8.0.
Disable test for IP2LocationBinary because it needs binary file. Travis CI test has also never passed.
|
Once this is merged, I'll also add a separate GitHub Actions workflow in each provider for testing in "sub-repositories". |
Nyholm
approved these changes
Mar 13, 2021
| fail-fast: false | ||
| matrix: | ||
| php-version: ['7.3', '7.4', '8.0'] | ||
| provider: |
There was a problem hiding this comment.
We could do something like this if we don't want to list all providers:
https://github.com/brefphp/extra-php-extensions/blob/master/.github/workflows/ci.yml#L19
There was a problem hiding this comment.
I must admit I'm not sure what the echo "::set-output name=list::$(ls layers | jq -R -s -c 'split("\n")[:-1]')" command does 😁
Use `composer update` insted of `composer install`.
Use `composer update` insted of `composer install`.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1100