[native_assets] Roll dependencies #166282

dcharkes · 2025-03-31T19:18:44Z

Updating the dart-lang/native dependencies to the ones published today.

No functional changes, but CodeAsset does not expose an architecture and os anymore (dart-lang/native#2127). Instead these should be taken from what is passed in for the CodeConfig. This PR refactors the DartBuildResult to carry around the Target with CodeAssets as FlutterCodeAssets.

(This PR avoid refactoring relevant code due to #164094 already refactoring this code.)

bkonyi

Generally LGTM with a couple of nits.

bkonyi · 2025-04-01T14:46:48Z

packages/flutter_tools/lib/src/isolated/native_assets/native_assets.dart

  final List<Uri> dependencies;

  Map<String, Object?> toJson() => <String, Object?>{
    'dependencies': <Object?>[for (final Uri dep in dependencies) dep.toString()],
-    'code_assets': <Object?>[for (final CodeAsset code in codeAssets) code.encode().toJson()],
+    'code_assets': <Object?>[


Nit for a possible follow up PR: if we're encoding / decoding JSON, we should define keys as constants to avoid accidentally introducing bugs with typos.

bkonyi · 2025-04-01T14:47:02Z

packages/flutter_tools/lib/src/isolated/native_assets/native_assets.dart

  ];
 }

+class FlutterCodeAsset {


This should have some basic documentation.

Roll Flutter from a0b1b3253416 to 02f13c37841f (37 revisions) flutter/flutter@a0b1b32...02f13c3 2025-04-03 engine-flutter-autoroll@skia.org Roll Packages from 07496eb to 4a36dc6 (3 revisions) (flutter/flutter#166542) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from b67e53719e78 to 5f65df75febd (2 revisions) (flutter/flutter#166538) 2025-04-03 magder@google.com Update docs to debug the Android embedder (flutter/flutter#166170) 2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 72562ca93bb5 to d174ec16c3ea (1 revision) (flutter/flutter#166525) 2025-04-03 matej.knopp@gmail.com [macOS] Implement merged UI and platform thread (flutter/flutter#162883) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from f91412f5d89d to b67e53719e78 (1 revision) (flutter/flutter#166527) 2025-04-03 engine-flutter-autoroll@skia.org Roll Packages from 125c117 to 07496eb (31 revisions) (flutter/flutter#166457) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 2be12bc2668b to f91412f5d89d (2 revisions) (flutter/flutter#166517) 2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 2a1a13cc3a91 to 72562ca93bb5 (2 revisions) (flutter/flutter#166514) 2025-04-03 dacoharkes@google.com [native_assets] Roll dependencies (flutter/flutter#166282) 2025-04-03 bruno.leroux@gmail.com Fix read only TextField focus traversal on macOS (flutter/flutter#166056) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from c106d7831592 to 2be12bc2668b (1 revision) (flutter/flutter#166509) 2025-04-03 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from v7PGvypiiWLO8PbsZ... to vYisSsIgqw0mqFRVJ... (flutter/flutter#166508) 2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from b8b4076b1237 to 2a1a13cc3a91 (1 revision) (flutter/flutter#166504) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 75a0ec473181 to c106d7831592 (1 revision) (flutter/flutter#166499) 2025-04-03 34465683+rkishan516@users.noreply.github.com Migrate to Theme.brightnessOf method (flutter/flutter#163950) 2025-04-03 34465683+rkishan516@users.noreply.github.com Fix: Range slider show overlay for both thumbs on hovering one (flutter/flutter#165393) 2025-04-03 victorsanniay@gmail.com Deprecate ExpansionTileController (flutter/flutter#166368) 2025-04-03 kalathiyadimil@gmail.com Add styling parameters in `PopupMenuDivider` (flutter/flutter#164790) 2025-04-03 matanlurey@users.noreply.github.com Fix ISSUE_TEMPLATE Ordering: `10 < 9`, but `10 > 09` (flutter/flutter#166455) 2025-04-03 katelovett@google.com Skip flaking scheduler test (flutter/flutter#166471) 2025-04-02 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#166043) 2025-04-02 yjbanov@google.com [a11y] add SemanticsValidationResult (flutter/flutter#165935) 2025-04-02 58529443+srujzs@users.noreply.github.com Remove unnecessary cache busting mechanism in hot restart (flutter/flutter#166295) 2025-04-02 engine-flutter-autoroll@skia.org Roll Skia from 52cbb917fffd to 75a0ec473181 (21 revisions) (flutter/flutter#166484) 2025-04-02 30870216+gaaclarke@users.noreply.github.com Started pixel aligning hairlines (flutter/flutter#166351) 2025-04-02 47866232+chunhtai@users.noreply.github.com Adds semantics role and adjust semantics for navigation bar (flutter/flutter#162467) 2025-04-02 jacksongardner@google.com Reland "[skwasm] Dynamic Threading" (flutter/flutter#166454) 2025-04-02 dkwingsmt@users.noreply.github.com [dart:ui] Add `Path.addRSuperellipse` (flutter/flutter#166045) 2025-04-02 34465683+rkishan516@users.noreply.github.com Fix: Hero animation for page transition (flutter/flutter#164469) 2025-04-02 34465683+rkishan516@users.noreply.github.com Fix: DelegateTransition for cupertino sheet route (flutter/flutter#164675) 2025-04-02 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from AEdsljKmUiPk92Wvv... to FZdRtNwH7jmADecj6... (flutter/flutter#166383) 2025-04-02 jonahwilliams@google.com [Impeller] cache for text shadows. (flutter/flutter#166228) 2025-04-02 34871572+gmackall@users.noreply.github.com Convert `AppPluginLoaderPlugin` to Kotlin, and add `NativePluginLoaderReflectionBridge` to expose it in Kotlin (flutter/flutter#166027) 2025-04-02 engine-flutter-autoroll@skia.org Roll Dart SDK from 4e1f02bc704f to b8b4076b1237 (7 revisions) (flutter/flutter#166474) 2025-04-02 mit@google.com Update Roadmap (flutter/flutter#166332) 2025-04-02 matanlurey@users.noreply.github.com Update `CODEOWNERS` (flutter/flutter#166444) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose ...

Roll Flutter from a0b1b3253416 to 02f13c37841f (37 revisions) flutter/flutter@a0b1b32...02f13c3 2025-04-03 engine-flutter-autoroll@skia.org Roll Packages from d10d5af to 95f8e65 (3 revisions) (flutter/flutter#166542) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from b67e53719e78 to 5f65df75febd (2 revisions) (flutter/flutter#166538) 2025-04-03 magder@google.com Update docs to debug the Android embedder (flutter/flutter#166170) 2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 72562ca93bb5 to d174ec16c3ea (1 revision) (flutter/flutter#166525) 2025-04-03 matej.knopp@gmail.com [macOS] Implement merged UI and platform thread (flutter/flutter#162883) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from f91412f5d89d to b67e53719e78 (1 revision) (flutter/flutter#166527) 2025-04-03 engine-flutter-autoroll@skia.org Roll Packages from 0d5d57b to d10d5af (31 revisions) (flutter/flutter#166457) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 2be12bc2668b to f91412f5d89d (2 revisions) (flutter/flutter#166517) 2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 2a1a13cc3a91 to 72562ca93bb5 (2 revisions) (flutter/flutter#166514) 2025-04-03 dacoharkes@google.com [native_assets] Roll dependencies (flutter/flutter#166282) 2025-04-03 bruno.leroux@gmail.com Fix read only TextField focus traversal on macOS (flutter/flutter#166056) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from c106d7831592 to 2be12bc2668b (1 revision) (flutter/flutter#166509) 2025-04-03 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from v7PGvypiiWLO8PbsZ... to vYisSsIgqw0mqFRVJ... (flutter/flutter#166508) 2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from b8b4076b1237 to 2a1a13cc3a91 (1 revision) (flutter/flutter#166504) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 75a0ec473181 to c106d7831592 (1 revision) (flutter/flutter#166499) 2025-04-03 34465683+rkishan516@users.noreply.github.com Migrate to Theme.brightnessOf method (flutter/flutter#163950) 2025-04-03 34465683+rkishan516@users.noreply.github.com Fix: Range slider show overlay for both thumbs on hovering one (flutter/flutter#165393) 2025-04-03 victorsanniay@gmail.com Deprecate ExpansionTileController (flutter/flutter#166368) 2025-04-03 kalathiyadimil@gmail.com Add styling parameters in `PopupMenuDivider` (flutter/flutter#164790) 2025-04-03 matanlurey@users.noreply.github.com Fix ISSUE_TEMPLATE Ordering: `10 < 9`, but `10 > 09` (flutter/flutter#166455) 2025-04-03 katelovett@google.com Skip flaking scheduler test (flutter/flutter#166471) 2025-04-02 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#166043) 2025-04-02 yjbanov@google.com [a11y] add SemanticsValidationResult (flutter/flutter#165935) 2025-04-02 58529443+srujzs@users.noreply.github.com Remove unnecessary cache busting mechanism in hot restart (flutter/flutter#166295) 2025-04-02 engine-flutter-autoroll@skia.org Roll Skia from 52cbb917fffd to 75a0ec473181 (21 revisions) (flutter/flutter#166484) 2025-04-02 30870216+gaaclarke@users.noreply.github.com Started pixel aligning hairlines (flutter/flutter#166351) 2025-04-02 47866232+chunhtai@users.noreply.github.com Adds semantics role and adjust semantics for navigation bar (flutter/flutter#162467) 2025-04-02 jacksongardner@google.com Reland "[skwasm] Dynamic Threading" (flutter/flutter#166454) 2025-04-02 dkwingsmt@users.noreply.github.com [dart:ui] Add `Path.addRSuperellipse` (flutter/flutter#166045) 2025-04-02 34465683+rkishan516@users.noreply.github.com Fix: Hero animation for page transition (flutter/flutter#164469) 2025-04-02 34465683+rkishan516@users.noreply.github.com Fix: DelegateTransition for cupertino sheet route (flutter/flutter#164675) 2025-04-02 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from AEdsljKmUiPk92Wvv... to FZdRtNwH7jmADecj6... (flutter/flutter#166383) 2025-04-02 jonahwilliams@google.com [Impeller] cache for text shadows. (flutter/flutter#166228) 2025-04-02 34871572+gmackall@users.noreply.github.com Convert `AppPluginLoaderPlugin` to Kotlin, and add `NativePluginLoaderReflectionBridge` to expose it in Kotlin (flutter/flutter#166027) 2025-04-02 engine-flutter-autoroll@skia.org Roll Dart SDK from 4e1f02bc704f to b8b4076b1237 (7 revisions) (flutter/flutter#166474) 2025-04-02 mit@google.com Update Roadmap (flutter/flutter#166332) 2025-04-02 matanlurey@users.noreply.github.com Update `CODEOWNERS` (flutter/flutter#166444) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose ...

dcharkes added 3 commits March 31, 2025 21:07

[native assets] Move away from CodeAsset.architecture

c5d4075

[native assets] Roll dependencies

bb2990a

cleanup

aea8370

dcharkes requested review from a team and matanlurey as code owners March 31, 2025 19:18

github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. a: desktop Running on desktop team-ios Owned by iOS platform team labels Mar 31, 2025

dcharkes requested a review from bkonyi March 31, 2025 19:18

dcharkes added 3 commits March 31, 2025 21:27

fix typo

fc2b720

fix tests

386ada9

fix test

bfb3ede

matanlurey removed their request for review March 31, 2025 20:15

Merge branch 'master' into roll-native-assets-2025-04-01

baa4f89

dcharkes requested a review from mosuem April 1, 2025 07:24

bkonyi approved these changes Apr 1, 2025

View reviewed changes

dcharkes added 2 commits April 1, 2025 19:39

address comment

a99cfd3

Merge branch 'master' into roll-native-assets-2025-04-01

785e54d

mosuem approved these changes Apr 2, 2025

View reviewed changes

dcharkes added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 2, 2025

auto-submit bot added this pull request to the merge queue Apr 2, 2025

matanlurey removed this pull request from the merge queue due to a manual request Apr 2, 2025

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 2, 2025

dcharkes added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 3, 2025

auto-submit bot added this pull request to the merge queue Apr 3, 2025

Merged via the queue into master with commit dec31cb Apr 3, 2025
152 checks passed

auto-submit bot deleted the roll-native-assets-2025-04-01 branch April 3, 2025 06:11

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 3, 2025

engine-flutter-autoroll mentioned this pull request Apr 3, 2025

Roll Flutter from a0b1b3253416 to 275ad8da5b97 (30 revisions) flutter/packages#8987

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025

dec31cb [native_assets] Roll dependencies (flutter/flutter#166282)

54d05b2

engine-flutter-autoroll mentioned this pull request Apr 3, 2025

Roll Flutter from a0b1b3253416 to 6df932243c12 (31 revisions) flutter/packages#8989

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025

dec31cb [native_assets] Roll dependencies (flutter/flutter#166282)

8c94c59

engine-flutter-autoroll mentioned this pull request Apr 3, 2025

Roll Flutter from a0b1b3253416 to 3237222b6211 (33 revisions) flutter/packages#8991

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025

dec31cb [native_assets] Roll dependencies (flutter/flutter#166282)

a28d804

engine-flutter-autoroll mentioned this pull request Apr 3, 2025

Roll Flutter from a0b1b3253416 to 269d544a9b9a (34 revisions) flutter/packages#8993

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025

dec31cb [native_assets] Roll dependencies (flutter/flutter#166282)

b2a2e44

engine-flutter-autoroll mentioned this pull request Apr 3, 2025

Roll Flutter from a0b1b3253416 to 73590fb0d2b7 (35 revisions) flutter/packages#8994

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025

dec31cb [native_assets] Roll dependencies (flutter/flutter#166282)

a76abde

engine-flutter-autoroll mentioned this pull request Apr 3, 2025

Roll Flutter from a0b1b3253416 to ceec33f16bea (36 revisions) flutter/packages#8995

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025

dec31cb [native_assets] Roll dependencies (flutter/flutter#166282)

ee5e1fb

engine-flutter-autoroll mentioned this pull request Apr 3, 2025

Roll Flutter from a0b1b3253416 to 02f13c37841f (37 revisions) flutter/packages#8996

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025

dec31cb [native_assets] Roll dependencies (flutter/flutter#166282)

4b6f7d3

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

dec31cb [native_assets] Roll dependencies (flutter/flutter#166282)

5444172

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

dec31cb [native_assets] Roll dependencies (flutter/flutter#166282)

5d02b86

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

dec31cbab [native_assets] Roll dependencies (flutter/flutter#166282)

41111b6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[native_assets] Roll dependencies #166282

[native_assets] Roll dependencies #166282

Uh oh!

dcharkes commented Mar 31, 2025 •

edited

Loading

Uh oh!

bkonyi left a comment

Uh oh!

bkonyi Apr 1, 2025

Uh oh!

bkonyi Apr 1, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

[native_assets] Roll dependencies #166282

[native_assets] Roll dependencies #166282

Uh oh!

Conversation

dcharkes commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bkonyi left a comment

Choose a reason for hiding this comment

Uh oh!

bkonyi Apr 1, 2025

Choose a reason for hiding this comment

Uh oh!

bkonyi Apr 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dcharkes commented Mar 31, 2025 •

edited

Loading