Skip to content

Commit 4a36dc6

Browse files
authored
[all_packages] Enforce property assignment for compile sdk over method assignment (#8897)
No issue I just noticed that we were almost consistent in our approach to compileSdk.
1 parent eaf475c commit 4a36dc6

File tree

45 files changed

+100
-60
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

45 files changed

+100
-60
lines changed

packages/camera/camera/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if (flutterVersionName == null) {
2424

2525
android {
2626
namespace 'io.flutter.plugins.cameraexample'
27-
compileSdk flutter.compileSdkVersion
27+
compileSdk = flutter.compileSdkVersion
2828

2929

3030
defaultConfig {

packages/camera/camera_android/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if (flutterVersionName == null) {
2424

2525
android {
2626
namespace 'io.flutter.plugins.cameraexample'
27-
compileSdk flutter.compileSdkVersion
27+
compileSdk = flutter.compileSdkVersion
2828

2929

3030
defaultConfig {

packages/camera/camera_android_camerax/example/android/app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ if (flutterVersionName == null) {
2424

2525
android {
2626
namespace 'io.flutter.plugins.cameraxexample'
27-
compileSdk flutter.compileSdkVersion
28-
ndkVersion flutter.ndkVersion
27+
compileSdk = flutter.compileSdkVersion
28+
ndkVersion = flutter.ndkVersion
2929

3030
compileOptions {
3131
sourceCompatibility JavaVersion.VERSION_11

packages/espresso/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ if (flutterVersionName == null) {
2323
}
2424

2525
android {
26-
compileSdk flutter.compileSdkVersion
26+
compileSdk = flutter.compileSdkVersion
2727
// TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html).
2828
namespace "com.example.espresso_example"
2929

packages/extension_google_sign_in_as_googleapis_auth/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if (flutterVersionName == null) {
2424
}
2525

2626
android {
27-
compileSdk flutter.compileSdkVersion
27+
compileSdk = flutter.compileSdkVersion
2828

2929
compileOptions {
3030
sourceCompatibility JavaVersion.VERSION_11

packages/file_selector/file_selector/example/android/app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ if (flutterVersionName == null) {
2424

2525
android {
2626
namespace "dev.flutter.plugins.file_selector_example"
27-
compileSdk flutter.compileSdkVersion
28-
ndkVersion flutter.ndkVersion
27+
compileSdk = flutter.compileSdkVersion
28+
ndkVersion = flutter.ndkVersion
2929

3030
compileOptions {
3131
sourceCompatibility JavaVersion.VERSION_11

packages/file_selector/file_selector_android/example/android/app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ if (flutterVersionName == null) {
2424

2525
android {
2626
namespace "dev.flutter.packages.file_selector_android_example"
27-
compileSdk flutter.compileSdkVersion
28-
ndkVersion flutter.ndkVersion
27+
compileSdk = flutter.compileSdkVersion
28+
ndkVersion = flutter.ndkVersion
2929

3030
compileOptions {
3131
sourceCompatibility JavaVersion.VERSION_11

packages/flutter_adaptive_scaffold/example/android/app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ if (flutterVersionName == null) {
2323
}
2424

2525
android {
26-
compileSdk flutter.compileSdkVersion
27-
ndkVersion flutter.ndkVersion
26+
compileSdk = flutter.compileSdkVersion
27+
ndkVersion = flutter.ndkVersion
2828

2929
compileOptions {
3030
sourceCompatibility JavaVersion.VERSION_11

packages/flutter_image/example/android/app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ if (flutterVersionName == null) {
2424

2525
android {
2626
namespace "com.example.example"
27-
compileSdk flutter.compileSdkVersion
28-
ndkVersion flutter.ndkVersion
27+
compileSdk = flutter.compileSdkVersion
28+
ndkVersion = flutter.ndkVersion
2929

3030
compileOptions {
3131
sourceCompatibility JavaVersion.VERSION_11

packages/flutter_markdown/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ if (flutterVersionName == null) {
2323
}
2424

2525
android {
26-
compileSdk flutter.compileSdkVersion
26+
compileSdk = flutter.compileSdkVersion
2727

2828
compileOptions {
2929
sourceCompatibility JavaVersion.VERSION_11

packages/flutter_plugin_android_lifecycle/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if (flutterVersionName == null) {
2424

2525

2626
android {
27-
compileSdk flutter.compileSdkVersion
27+
compileSdk = flutter.compileSdkVersion
2828

2929

3030
defaultConfig {

packages/go_router/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ if (flutterVersionName == null) {
2323
}
2424

2525
android {
26-
compileSdk flutter.compileSdkVersion
26+
compileSdk = flutter.compileSdkVersion
2727

2828
compileOptions {
2929
sourceCompatibility JavaVersion.VERSION_11

packages/google_maps_flutter/google_maps_flutter/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ if (flutterVersionName == null) {
2323
}
2424

2525
android {
26-
compileSdk flutter.compileSdkVersion
26+
compileSdk = flutter.compileSdkVersion
2727

2828

2929
defaultConfig {

packages/google_maps_flutter/google_maps_flutter_android/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if (flutterVersionName == null) {
2424

2525
android {
2626
namespace 'io.flutter.plugins.googlemapsexample'
27-
compileSdk flutter.compileSdkVersion
27+
compileSdk = flutter.compileSdkVersion
2828

2929

3030
defaultConfig {

packages/google_sign_in/google_sign_in/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if (flutterVersionName == null) {
2424

2525
android {
2626
namespace 'io.flutter.plugins.googlesigninexample'
27-
compileSdk flutter.compileSdkVersion
27+
compileSdk = flutter.compileSdkVersion
2828

2929

3030
defaultConfig {

packages/google_sign_in/google_sign_in_android/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if (flutterVersionName == null) {
2424

2525
android {
2626
namespace 'io.flutter.plugins.googlesigninexample'
27-
compileSdk flutter.compileSdkVersion
27+
compileSdk = flutter.compileSdkVersion
2828

2929

3030
defaultConfig {

packages/image_picker/image_picker/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if (flutterVersionName == null) {
2424

2525
android {
2626
namespace 'io.flutter.plugins.imagepickerexample'
27-
compileSdk flutter.compileSdkVersion
27+
compileSdk = flutter.compileSdkVersion
2828
testOptions.unitTests.includeAndroidResources = true
2929

3030

packages/image_picker/image_picker_android/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if (flutterVersionName == null) {
2424

2525
android {
2626
namespace 'io.flutter.plugins.imagepickerexample'
27-
compileSdk flutter.compileSdkVersion
27+
compileSdk = flutter.compileSdkVersion
2828
testOptions.unitTests.includeAndroidResources = true
2929

3030

packages/in_app_purchase/in_app_purchase/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ android {
6262
}
6363
}
6464

65-
compileSdk flutter.compileSdkVersion
65+
compileSdk = flutter.compileSdkVersion
6666

6767

6868
defaultConfig {

packages/in_app_purchase/in_app_purchase_android/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ if (!configured) {
5353

5454
android {
5555
namespace 'io.flutter.plugins.inapppurchaseexample'
56-
compileSdk flutter.compileSdkVersion
56+
compileSdk = flutter.compileSdkVersion
5757

5858
signingConfigs {
5959
release {

packages/interactive_media_ads/example/android/app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ if (flutterVersionName == null) {
2424

2525
android {
2626
namespace "dev.flutter.packages.interactive_media_ads_example"
27-
compileSdk flutter.compileSdkVersion
28-
ndkVersion flutter.ndkVersion
27+
compileSdk = flutter.compileSdkVersion
28+
ndkVersion = flutter.ndkVersion
2929

3030
compileOptions {
3131
sourceCompatibility JavaVersion.VERSION_11

packages/local_auth/local_auth/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if (flutterVersionName == null) {
2424

2525
android {
2626
namespace 'io.flutter.plugins.localauthexample'
27-
compileSdk flutter.compileSdkVersion
27+
compileSdk = flutter.compileSdkVersion
2828

2929

3030
defaultConfig {

packages/local_auth/local_auth_android/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if (flutterVersionName == null) {
2424

2525
android {
2626
namespace 'io.flutter.plugins.localauthexample'
27-
compileSdk flutter.compileSdkVersion
27+
compileSdk = flutter.compileSdkVersion
2828

2929

3030
defaultConfig {

packages/palette_generator/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ if (flutterVersionName == null) {
1717
}
1818

1919
android {
20-
compileSdk flutter.compileSdkVersion
20+
compileSdk = flutter.compileSdkVersion
2121

2222

2323
defaultConfig {

packages/path_provider/path_provider/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if (flutterVersionName == null) {
2424

2525
android {
2626
namespace 'io.flutter.plugins.pathproviderexample'
27-
compileSdk flutter.compileSdkVersion
27+
compileSdk = flutter.compileSdkVersion
2828

2929

3030
defaultConfig {

packages/path_provider/path_provider_android/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if (flutterVersionName == null) {
2424

2525
android {
2626
namespace 'io.flutter.plugins.pathproviderexample'
27-
compileSdk flutter.compileSdkVersion
27+
compileSdk = flutter.compileSdkVersion
2828

2929

3030
defaultConfig {

packages/pigeon/example/app/android/app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ if (flutterVersionName == null) {
2424

2525
android {
2626
namespace "dev.flutter.pigeon_example_app"
27-
compileSdk flutter.compileSdkVersion
28-
ndkVersion flutter.ndkVersion
27+
compileSdk = flutter.compileSdkVersion
28+
ndkVersion = flutter.ndkVersion
2929

3030
compileOptions {
3131
sourceCompatibility JavaVersion.VERSION_11

packages/pigeon/platform_tests/alternate_language_test_plugin/example/android/app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ if (flutterVersionName == null) {
2424

2525
android {
2626
namespace 'com.example.alternate_language_test_plugin_example'
27-
compileSdk flutter.compileSdkVersion
28-
ndkVersion flutter.ndkVersion
27+
compileSdk = flutter.compileSdkVersion
28+
ndkVersion = flutter.ndkVersion
2929

3030
compileOptions {
3131
sourceCompatibility JavaVersion.VERSION_11

packages/pigeon/platform_tests/test_plugin/example/android/app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ if (flutterVersionName == null) {
2424

2525
android {
2626
namespace 'com.example.test_plugin_example'
27-
compileSdk flutter.compileSdkVersion
28-
ndkVersion flutter.ndkVersion
27+
compileSdk = flutter.compileSdkVersion
28+
ndkVersion = flutter.ndkVersion
2929

3030
compileOptions {
3131
sourceCompatibility JavaVersion.VERSION_11

packages/quick_actions/quick_actions/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if (flutterVersionName == null) {
2424

2525
android {
2626
namespace 'io.flutter.plugins.quickactionsexample'
27-
compileSdk flutter.compileSdkVersion
27+
compileSdk = flutter.compileSdkVersion
2828

2929

3030
defaultConfig {

packages/quick_actions/quick_actions_android/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ def androidXTestVersion = '1.4.0'
2626

2727
android {
2828
namespace 'io.flutter.plugins.quickactionsexample'
29-
compileSdk flutter.compileSdkVersion
29+
compileSdk = flutter.compileSdkVersion
3030

3131

3232
defaultConfig {

packages/rfw/example/hello/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if (flutterVersionName == null) {
2424

2525
android {
2626
namespace 'dev.flutter.rfw.examples.hello'
27-
compileSdk flutter.compileSdkVersion
27+
compileSdk = flutter.compileSdkVersion
2828

2929
compileOptions {
3030
sourceCompatibility JavaVersion.VERSION_11

packages/rfw/example/local/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if (flutterVersionName == null) {
2424

2525
android {
2626
namespace 'dev.flutter.rfw.examples.local'
27-
compileSdk flutter.compileSdkVersion
27+
compileSdk = flutter.compileSdkVersion
2828

2929
compileOptions {
3030
sourceCompatibility JavaVersion.VERSION_11

packages/rfw/example/remote/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if (flutterVersionName == null) {
2424

2525
android {
2626
namespace 'dev.flutter.rfw.examples.remote'
27-
compileSdk flutter.compileSdkVersion
27+
compileSdk = flutter.compileSdkVersion
2828

2929
compileOptions {
3030
sourceCompatibility JavaVersion.VERSION_11

packages/shared_preferences/shared_preferences/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if (flutterVersionName == null) {
2424

2525
android {
2626
namespace 'io.flutter.plugins.sharedpreferencesexample'
27-
compileSdk flutter.compileSdkVersion
27+
compileSdk = flutter.compileSdkVersion
2828

2929
sourceSets {
3030
main.java.srcDirs += 'src/main/kotlin'

packages/shared_preferences/shared_preferences_android/example/android/app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ if (flutterVersionName == null) {
3737

3838
android {
3939
namespace "dev.flutter.plugins.shared_preferences_example"
40-
compileSdk flutter.compileSdkVersion
41-
ndkVersion flutter.ndkVersion
40+
compileSdk = flutter.compileSdkVersion
41+
ndkVersion = flutter.ndkVersion
4242

4343
compileOptions {
4444
sourceCompatibility JavaVersion.VERSION_11

packages/two_dimensional_scrollables/example/android/app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ if (flutterVersionName == null) {
2424

2525
android {
2626
namespace 'dev.flutter.packages.two_dimensional_scrollables.example'
27-
compileSdk flutter.compileSdkVersion
28-
ndkVersion flutter.ndkVersion
27+
compileSdk = flutter.compileSdkVersion
28+
ndkVersion = flutter.ndkVersion
2929

3030
compileOptions {
3131
sourceCompatibility JavaVersion.VERSION_11

packages/url_launcher/url_launcher/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if (flutterVersionName == null) {
2424

2525
android {
2626
namespace 'io.flutter.plugins.urllauncherexample'
27-
compileSdk flutter.compileSdkVersion
27+
compileSdk = flutter.compileSdkVersion
2828

2929

3030
defaultConfig {

packages/url_launcher/url_launcher_android/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if (flutterVersionName == null) {
2424

2525
android {
2626
namespace 'io.flutter.plugins.urllauncherexample'
27-
compileSdk flutter.compileSdkVersion
27+
compileSdk = flutter.compileSdkVersion
2828

2929

3030
defaultConfig {

packages/video_player/video_player/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if (flutterVersionName == null) {
2424

2525
android {
2626
namespace 'io.flutter.plugins.videoplayerexample'
27-
compileSdk flutter.compileSdkVersion
27+
compileSdk = flutter.compileSdkVersion
2828

2929
compileOptions {
3030
sourceCompatibility JavaVersion.VERSION_11

packages/video_player/video_player_android/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if (flutterVersionName == null) {
2424

2525
android {
2626
namespace 'io.flutter.plugins.videoplayerexample'
27-
compileSdk flutter.compileSdkVersion
27+
compileSdk = flutter.compileSdkVersion
2828

2929
compileOptions {
3030
sourceCompatibility JavaVersion.VERSION_11

packages/webview_flutter/webview_flutter/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if (flutterVersionName == null) {
2424

2525
android {
2626
namespace 'io.flutter.plugins.webviewflutterexample'
27-
compileSdk flutter.compileSdkVersion
27+
compileSdk = flutter.compileSdkVersion
2828

2929

3030
defaultConfig {

0 commit comments

Comments
 (0)