Skip to content

phpDoc: add @throws InvalidArgumentException in JWT::decode() #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2021
Merged

phpDoc: add @throws InvalidArgumentException in JWT::decode() #320

merged 2 commits into from
Mar 5, 2021

Conversation

bborrel
Copy link

@bborrel bborrel commented Feb 2, 2021

No description provided.

@google-cla
Copy link

google-cla bot commented Feb 2, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Feb 2, 2021
@bborrel
Copy link
Author

bborrel commented Feb 2, 2021 via email

@google-cla
Copy link

google-cla bot commented Feb 2, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: yes and removed cla: no labels Feb 2, 2021
@google-cla
Copy link

google-cla bot commented Feb 19, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@bshaffer bshaffer merged commit 7b4f4d2 into firebase:master Mar 5, 2021
alancting added a commit to alancting/php-microsoft-jwt that referenced this pull request Mar 15, 2021
* docs: add JWK usage to README (firebase#307)

* fix: add missing use statement in JWK (firebase#303)

* chore: add phpdoc @throws in JWT::decode (firebase#320)

* chore: remove leading backslashes in imports (firebase#301)

Co-authored-by: Brent Shaffer <betterbrent@google.com>

* Code for microsoft jwt

* Add logic to use CURL retrieving Config and JWT (#5)

* Add logic to use CURL retrieving Config and JWT
* Amend coveralls.yml for handling PHP 7
Co-authored-by: neoblackie <tony.cheung@hkuspace.hku.hk>

* v1.1.0 release update

* Sync with firebase/php-jwt:v5.2.1

* Conflixt fix

Co-authored-by: Brent Shaffer <betterbrent@google.com>
Co-authored-by: Grant Anderson <pendenga@gmail.com>
Co-authored-by: Benoit Borrel <234378+bborrel@users.noreply.github.com>
Co-authored-by: Ashutosh K Tripathi <kewlashu@gmail.com>
Co-authored-by: Neodeblackie <80467285+Neodeblackie@users.noreply.github.com>
@bborrel bborrel deleted the patch-2 branch May 20, 2021 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants