InvalidArgumentException - Issue #302 #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add InvalidArgumentException use statement to JWK.php
|
Please also try to add the tests that seems to be missing (which also proves the issue). |
Added tests to validate. Tests fail on master.
bshaffer
approved these changes
Feb 11, 2021
alancting
added a commit
to alancting/php-microsoft-jwt
that referenced
this pull request
Mar 15, 2021
* docs: add JWK usage to README (firebase#307) * fix: add missing use statement in JWK (firebase#303) * chore: add phpdoc @throws in JWT::decode (firebase#320) * chore: remove leading backslashes in imports (firebase#301) Co-authored-by: Brent Shaffer <betterbrent@google.com> * Code for microsoft jwt * Add logic to use CURL retrieving Config and JWT (#5) * Add logic to use CURL retrieving Config and JWT * Amend coveralls.yml for handling PHP 7 Co-authored-by: neoblackie <tony.cheung@hkuspace.hku.hk> * v1.1.0 release update * Sync with firebase/php-jwt:v5.2.1 * Conflixt fix Co-authored-by: Brent Shaffer <betterbrent@google.com> Co-authored-by: Grant Anderson <pendenga@gmail.com> Co-authored-by: Benoit Borrel <234378+bborrel@users.noreply.github.com> Co-authored-by: Ashutosh K Tripathi <kewlashu@gmail.com> Co-authored-by: Neodeblackie <80467285+Neodeblackie@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add InvalidArgumentException use statement to JWK.php