Skip to content

Add header and stub for User Messaging Platform SDK. #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 59 commits into from
Aug 3, 2023
Merged

Add header and stub for User Messaging Platform SDK. #1391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
0f83789
Added initial header and empty stub for UMP ConsentInfo.
jonsimantov Jul 18, 2023
61b9efe
Added error message getters.
jonsimantov Jul 18, 2023
092f76e
Add ConsentInfo methods.
jonsimantov Jul 18, 2023
1de4ac6
Format code.
jonsimantov Jul 18, 2023
1074858
Comment tweak.
jonsimantov Jul 18, 2023
4c8ff0b
Fix lint error.
jonsimantov Jul 18, 2023
0654070
Add LastResult methods.
jonsimantov Jul 18, 2023
f6399ce
Additional implementation.
jonsimantov Jul 18, 2023
5dfcf28
Fix build.
jonsimantov Jul 18, 2023
9c21d3b
Fix lint errors.
jonsimantov Jul 18, 2023
9552f7a
Added integration test for initializing library.
jonsimantov Jul 18, 2023
f6efa69
Update test.
jonsimantov Jul 18, 2023
0727c9e
Fix initialization.
jonsimantov Jul 18, 2023
29f1334
Add internal methods.
jonsimantov Jul 18, 2023
93bdab8
Add mappings from interface class to internal class.
jonsimantov Jul 18, 2023
493c26f
Add string conversion for error code.
jonsimantov Jul 19, 2023
4372451
Add conversion of form errors.
jonsimantov Jul 19, 2023
1ffa00d
Add stub function implementations.
jonsimantov Jul 19, 2023
5f03ca8
Add stub operations and unit tests.
jonsimantov Jul 19, 2023
1b20566
Add missing file.
jonsimantov Jul 19, 2023
1cec993
Format code.
jonsimantov Jul 19, 2023
d73daca
Merge branch 'main' into feature/ump-sdk-headers
jonsimantov Jul 19, 2023
3d9a822
Add check for form.
jonsimantov Jul 19, 2023
b95ae12
Merge branch 'feature/ump-sdk-headers' of https://github.com/firebase…
jonsimantov Jul 19, 2023
ff0b328
Add test for expected error not specifying tag for age of consent.
jonsimantov Jul 19, 2023
56e18e2
Clean up tests by moving initialization into shared method.
jonsimantov Jul 19, 2023
6934de7
Fix TODO.
jonsimantov Jul 19, 2023
3601d3c
Fix lint issues.
jonsimantov Jul 19, 2023
1a27b77
Add Doxygen comments to public interface.
jonsimantov Jul 19, 2023
5f9ab35
Add LastResult implementations, and tests to confirm.
jonsimantov Jul 19, 2023
f4aef9d
Add method stubs for new UserMessagingPlatform API.
jonsimantov Jul 19, 2023
d270607
Handle invalid internal pointers.
jonsimantov Jul 19, 2023
d275462
Format code.
jonsimantov Jul 19, 2023
b436027
Add objective-C header for FormParent.
jonsimantov Jul 19, 2023
a9fcc72
Merge branch 'feature/ump-sdk-headers' into feature/ump-sdk-headers-n…
jonsimantov Jul 19, 2023
8e64afe
Merge branch 'main' into feature/ump-sdk-headers
jonsimantov Jul 19, 2023
4e7609b
Add ump.h to top-level CMake file, so it gets added to the framework.
jonsimantov Jul 19, 2023
c5e4a24
Merge branch 'feature/ump-sdk-headers' of https://github.com/firebase…
jonsimantov Jul 19, 2023
134bd3f
Change RequestConsentStatus to RequestConsentInfoUpdate.
jonsimantov Jul 20, 2023
8ce86c5
Update integration test method name.
jonsimantov Jul 20, 2023
6a050a6
Update all Future return types to Future<void>.
jonsimantov Jul 20, 2023
8242fed
Add a test to ensure that GetInstance() always returns the same insta…
jonsimantov Jul 20, 2023
c726ef8
Merge branch 'feature/ump-sdk-headers' into feature/ump-sdk-headers-n…
jonsimantov Jul 25, 2023
2be2571
Change params to a struct.
jonsimantov Jul 25, 2023
8a320b4
Document the workflow that the stub simulates.
jonsimantov Jul 25, 2023
c712a0d
Clean up stub workflow for privacy options.
jonsimantov Jul 25, 2023
4b51480
Add comment to struct.
jonsimantov Jul 25, 2023
d0aaed7
Fix comments & enum text.
jonsimantov Jul 25, 2023
3a772de
Newline removed.
jonsimantov Jul 25, 2023
64cfce1
Lint error.
jonsimantov Jul 25, 2023
63dd1bd
Merge branch 'feature_branch/ump-sdk' into feature/ump-sdk-headers
jonsimantov Jul 25, 2023
8889fbc
Added comment explaining what EEA means.
jonsimantov Jul 27, 2023
c7c91ad
Merge branch 'feature_branch/ump-sdk' into feature/ump-sdk-headers
jonsimantov Jul 31, 2023
6b05423
Add a comment about ResetInfo in the UMP tests.
jonsimantov Aug 2, 2023
3c73c90
Add expectation for privacy also being unknown.
jonsimantov Aug 2, 2023
0585ce0
Move GetConsent*ErrorMessage to internal.
jonsimantov Aug 2, 2023
a5551d1
Update method documentation and fixed FormUnavailable/Available logic.
jonsimantov Aug 2, 2023
0da76af
Fix comments.
jonsimantov Aug 3, 2023
7495d9b
Merge branch 'feature/ump-sdk-headers' of https://github.com/firebase…
jonsimantov Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion app/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,10 @@ if (IOS)
${FIREBASE_SOURCE_DIR}/gma/src/include/firebase/gma/interstitial_ad.h
${FIREBASE_SOURCE_DIR}/gma/src/include/firebase/gma/internal/native_ad.h
${FIREBASE_SOURCE_DIR}/gma/src/include/firebase/gma/rewarded_ad.h
${FIREBASE_SOURCE_DIR}/gma/src/include/firebase/gma/types.h)
${FIREBASE_SOURCE_DIR}/gma/src/include/firebase/gma/types.h
${FIREBASE_SOURCE_DIR}/gma/src/include/firebase/gma/ump.h
${FIREBASE_SOURCE_DIR}/gma/src/include/firebase/gma/ump/consent_info.h
${FIREBASE_SOURCE_DIR}/gma/src/include/firebase/gma/ump/types.h)
set(installations_HDRS
${FIREBASE_SOURCE_DIR}/installations/src/include/firebase/installations.h)
set(messaging_HDRS
Expand Down
5 changes: 5 additions & 0 deletions gma/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@

# Common source files used by all platforms
set(common_SRCS
src/common/ump/consent_info.cc
src/common/ump/consent_info_internal.cc
src/common/gma_common.cc
src/common/ad_view.cc
src/common/ad_view_internal.cc
Expand All @@ -38,6 +40,7 @@ binary_to_array("gma_resources"
# Source files used by the Android implementation.
set(android_SRCS
${gma_resources_source}
src/stub/ump/consent_info_internal_stub.cc
src/android/ad_request_converter.cc
src/android/ad_error_android.cc
src/android/adapter_response_info_android.cc
Expand All @@ -51,6 +54,7 @@ set(android_SRCS

# Source files used by the iOS implementation.
set(ios_SRCS
src/stub/ump/consent_info_internal_stub.cc
src/ios/FADAdSize.mm
src/ios/FADAdView.mm
src/ios/FADInterstitialDelegate.mm
Expand All @@ -69,6 +73,7 @@ set(ios_SRCS

# Source files used by the stub implementation.
set(stub_SRCS
src/stub/ump/consent_info_internal_stub.cc
src/stub/ad_error_stub.cc
src/stub/adapter_response_info_stub.cc
src/stub/gma_stub.cc
Expand Down
Loading