Skip to content

Add header and stub for User Messaging Platform SDK. #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 59 commits into from
Aug 3, 2023
Merged

Add header and stub for User Messaging Platform SDK. #1391

merged 59 commits into from
Aug 3, 2023

Conversation

jonsimantov
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov changed the title In-progress: Added header and stub for User Messaging Platform SDK. Add header and stub for User Messaging Platform SDK. Jul 19, 2023
@jonsimantov jonsimantov requested a review from AlmostMatt July 19, 2023 18:05
@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Jul 19, 2023
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jul 19, 2023
@github-actions
Copy link

github-actions bot commented Jul 19, 2023 •
edited
Loading

Integration test with FLAKINESS (succeeded after retry)

Requested by @jonsimantov on commit 570104d
Last updated: Thu Aug 3 13:44 PDT 2023
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [2/3 os: windows macos] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
gma [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  FirebaseGmaTest.TestNativeAdLoad

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jul 19, 2023
@github-actions github-actions bot removed the tests: failed This PR's integration tests failed. label Jul 19, 2023
@jonsimantov jonsimantov marked this pull request as ready for review July 19, 2023 18:27
AlmostMatt
AlmostMatt reviewed Aug 1, 2023
View reviewed changes
Copy link
Contributor

@AlmostMatt AlmostMatt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The public API looks good, I added several suggestions to make the method documentation closer to the phrasing of iOS and Android docs. (I will update the API proposal comments similarly shortly)

AlmostMatt
AlmostMatt reviewed Aug 1, 2023
View reviewed changes
a-maurice
a-maurice reviewed Aug 1, 2023
View reviewed changes
AlmostMatt
AlmostMatt reviewed Aug 2, 2023
View reviewed changes
@jonsimantov
Copy link
Contributor Author

The public API looks good, I added several suggestions to make the method documentation closer to the phrasing of iOS and Android docs. (I will update the API proposal comments similarly shortly)

Thanks - I made all the changes you mentioned. PTAL.

@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Aug 2, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 2, 2023
AlmostMatt
AlmostMatt reviewed Aug 2, 2023
View reviewed changes
AlmostMatt
AlmostMatt reviewed Aug 2, 2023
View reviewed changes
@AlmostMatt AlmostMatt disabled auto-merge August 2, 2023 23:46
@jonsimantov jonsimantov enabled auto-merge (squash) August 3, 2023 17:12
@jonsimantov jonsimantov removed the tests: failed This PR's integration tests failed. label Aug 3, 2023
@jonsimantov jonsimantov merged commit 570104d into feature_branch/ump-sdk Aug 3, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. labels Aug 3, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 3, 2023
@firebase firebase locked and limited conversation to collaborators Sep 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@AlmostMatt AlmostMatt AlmostMatt approved these changes

@a-maurice a-maurice Awaiting requested review from a-maurice

Assignees

@AlmostMatt AlmostMatt

@a-maurice a-maurice

Labels
tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonsimantov @AlmostMatt @a-maurice