Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

New: Allow other orderings of implements/extends clauses (fixes #361) #363

Merged
merged 2 commits into from
Aug 19, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions lib/convert.js
Original file line number Diff line number Diff line change
Expand Up @@ -1277,19 +1277,13 @@ module.exports = function convert(config) {
}

const openBrace = nodeUtils.findNextToken(lastClassToken, ast);
const hasExtends = (heritageClauses.length && node.heritageClauses[0].token === SyntaxKind.ExtendsKeyword);
const superClass = heritageClauses.find(clause => clause.token === SyntaxKind.ExtendsKeyword);

let hasImplements = false;
let superClass;

if (hasExtends && heritageClauses[0].types.length > 0) {
superClass = heritageClauses.shift();
if (superClass.types[0] && superClass.types[0].typeArguments) {
result.superTypeParameters = convertTypeArgumentsToTypeParameters(superClass.types[0].typeArguments);
}
if (superClass && superClass.types[0] && superClass.types[0].typeArguments) {
result.superTypeParameters = convertTypeArgumentsToTypeParameters(superClass.types[0].typeArguments);
}

hasImplements = heritageClauses.length > 0;
const implementsClause = heritageClauses.find(clause => clause.token === SyntaxKind.ImplementsKeyword);

Object.assign(result, {
type: classNodeType,
Expand All @@ -1302,11 +1296,11 @@ module.exports = function convert(config) {
range: [openBrace.getStart(), result.range[1]],
loc: nodeUtils.getLocFor(openBrace.getStart(), node.end, ast)
},
superClass: (superClass ? convertChild(superClass.types[0].expression) : null)
superClass: (superClass && superClass.types[0] ? convertChild(superClass.types[0].expression) : null)
});

if (hasImplements) {
result.implements = heritageClauses[0].types.map(convertClassImplements);
if (implementsClause) {
result.implements = implementsClause.types.map(convertClassImplements);
}

if (node.decorators) {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
class ClassWithParentAndInterface extends MyOtherClass implements MyInterface {}
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
class ClassWithParentAndInterface implements MyInterface extends MyOtherClass {}
Loading