Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

New: Allow other orderings of implements/extends clauses (fixes #361) #363

Merged
merged 2 commits into from
Aug 19, 2017

Conversation

j-f1
Copy link
Contributor

@j-f1 j-f1 commented Aug 19, 2017

This allows for classes like

class ClassWithParentAndInterface implements MyInterface extends MyOtherClass {}

which currently do not parse the extends clause.

Fixes #361.

@eslintbot
Copy link

Thanks for the pull request, @j-f1! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary must be 72 characters or shorter. Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@j-f1 j-f1 force-pushed the class-implements-extends branch from 0544fd9 to 77e0a67 Compare August 19, 2017 11:31
@eslintbot
Copy link

LGTM

@j-f1
Copy link
Contributor Author

j-f1 commented Aug 19, 2017

I can’t reproduce that error locally on Node 5. Closing and reopening to restart the build.

@j-f1 j-f1 closed this Aug 19, 2017
@j-f1 j-f1 reopened this Aug 19, 2017
@j-f1 j-f1 changed the title New: Allow different orderings of class implements and extends clauses (fixes #361) New: Allow other orderings of implements/extends clauses (fixes #361) Aug 19, 2017
Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JamesHenry
Copy link
Member

I think I'll class this as a bug fix when I merge, because this should have always been the behaviour rather than it being a new feature.

Thanks again!

@JamesHenry JamesHenry merged commit 5f741a9 into eslint:master Aug 19, 2017
@j-f1 j-f1 deleted the class-implements-extends branch August 19, 2017 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants