Add Phoenix LiveEEx Template (.leex) file type support. #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add LiveView sigil (~L"""LiveView""") support in .ex. Update README.md
jbodah
reviewed
Mar 22, 2019
jbodah
reviewed
Mar 22, 2019
jbodah
reviewed
Mar 22, 2019
spec/syntax/sigil_spec.rb
Outdated
|
|
||
| it 'Live EEx' do | ||
| expect('~L"""liveview template"""').to include_elixir_syntax('elixirSigilDelimiter', '""""') | ||
| expect('~L"""liveview template"""').to include_elixir_syntax('elixirSigilDelimiter', '""""') |
There was a problem hiding this comment.
Are these expects different? Could we just have one?
There was a problem hiding this comment.
If possible it would be nice to get a test on the inner sigil syntax being recognized. I can see if I can get one written
There was a problem hiding this comment.
I removed the duplicated line, but haven't got time to write test for inner sigil syntax yet.
removed duplicated live view sigil spec
|
Merged in #490 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jbodah I closed the original #484 , please check this new pull quest, thank you.
Add Phoenix LiveEEx Template (
.leex) file syntax highlight support.Add LiveView sigil (~L"""LiveView""") syntax highlight support in
.exfile.Update README.md
Screen shot of
.leexsyntax highlight:Screen shot of LiveView sigil syntax highlight in
.ex: