Skip to content

Add LiveEEx template (.leex) syntax support #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Add LiveEEx template (.leex) syntax support #484

wants to merge 5 commits into from

Conversation

crunchysoul
Copy link

Add Phoenix LiveEEx Template (.leex) file type support.
Add LiveView sigil (~L"""LiveView""") support.

Below is a comparison screenshot:
compare_with_current

@jbodah
Copy link
Collaborator

jbodah commented Mar 21, 2019

@crunchysoul any reason for closing? I would like to incorporate some of these changes if possible

@crunchysoul
Copy link
Author

crunchysoul commented Mar 21, 2019

@crunchysoul any reason for closing? I would like to incorporate some of these changes if possible

hey @jbodah, I'm temperately closing the request due to:

  1. I haven't be able to add proper syntax support for contents within LiveView Sigil (~L """LiveView Contents""") in a .ex file, ideally these contents should have same syntax as .leex/.eex.
  2. removed LiveView sigil syntax support from .leex/.eex files.

I can reopen the pull request, I think it's still going to be an improvement in .leex file support.

@crunchysoul crunchysoul reopened this Mar 21, 2019
@crunchysoul
Copy link
Author

crunchysoul commented Mar 22, 2019

@jbodah I believe I have solved the LiveView Sigil syntax highlighting within .ex.

I will close this pull request and do a new one, because I don't want to pollute this request with all my testing push history.

Please check the new pull request #487 , thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants