Skip to content

Optional field id in hit class #2592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2024
Merged

Optional field id in hit class #2592

merged 1 commit into from
May 30, 2024

Conversation

l-trotta
Copy link
Contributor

@l-trotta l-trotta commented May 29, 2024

as the comment just above the field says:

'_id' is not available when using 'stored_fields: _none_'

Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
search 🔴 1433/2083 2016/2065

You can validate this API yourself by using the make validate target.

@l-trotta l-trotta merged commit b1f91f1 into main May 30, 2024
9 checks passed
@l-trotta l-trotta deleted the id-optional-hit branch May 30, 2024 08:02
Copy link
Contributor

The backport to 7.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-2592-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b1f91f1a0ae5d09da92cf0859b0ff92410cdb6e3
# Push it to GitHub
git push --set-upstream origin backport-2592-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17

Then, create a pull request where the base branch is 7.17 and the compare/head branch is backport-2592-to-7.17.

github-actions bot pushed a commit that referenced this pull request May 30, 2024
(cherry picked from commit b1f91f1)
github-actions bot pushed a commit that referenced this pull request May 30, 2024
(cherry picked from commit b1f91f1)
l-trotta added a commit that referenced this pull request May 30, 2024
(cherry picked from commit b1f91f1)

Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
l-trotta added a commit that referenced this pull request May 30, 2024
(cherry picked from commit b1f91f1)

Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
l-trotta added a commit that referenced this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants