Auto-generated code for main #2262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticmachine
force-pushed
the
generates_main_code
branch
4 times, most recently
from
493bcd4 to
d25c565
Compare
elasticmachine
force-pushed
the
generates_main_code
branch
from
d25c565 to
bbc1377
Compare
JoshMock
approved these changes
Jun 3, 2024
hluup
reviewed
Jul 18, 2024
| @@ -1413,7 +1413,7 @@ export type SearchHighlighterType = 'plain' | 'fvh' | 'unified' | string | |||
|
|
|||
| export interface SearchHit<TDocument = unknown> { | |||
| _index: IndexName | |||
| _id: Id | |||
| _id?: Id | |||
There was a problem hiding this comment.
How can I figure out why this can be undefined now? I can't seem to notice anything relevant in changelogs.
There was a problem hiding this comment.
Type definitions are generated from the specification. In this particular case, it looks like this change happened in elastic/elasticsearch-specification#2592.
There was a problem hiding this comment.
Thank you! This clears it up.
* @es_quirk '_id' is not available when using 'stored_fields: _none_'
* on a search request. Otherwise the field is always present on hits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled