Skip to content

[OTel instrumentation] Add path params and endpoint in opts to perform_request #2179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 48 commits into from
Sep 29, 2023
Merged

[OTel instrumentation] Add path params and endpoint in opts to perform_request #2179

merged 48 commits into from
Sep 29, 2023

Conversation

estolfo
Copy link
Contributor

@estolfo estolfo commented Aug 25, 2023 •
edited
Loading

This PR complements a PR in the transport client

This PR does the following:

  • Adds the path params and endpoint id to the perform_request args list so that the transport client can use the values for the OpenTelemetry instrumentation
  • Updates all endpoint files with the new functionality and new perform_request method signature (code was regenerated)
  • Adds a unit test for each of the endpoints verifying that the correct endpoint id and path params are passed

@estolfo estolfo mentioned this pull request Aug 25, 2023
Closed
@estolfo estolfo marked this pull request as draft August 25, 2023 11:23
@estolfo estolfo force-pushed the otel-native-2 branch 2 times, most recently from f7938c6 to f56b5e8 Compare August 30, 2023 08:47
@estolfo estolfo mentioned this pull request Sep 6, 2023
Merged
8 tasks
@estolfo estolfo marked this pull request as ready for review September 6, 2023 13:13
@estolfo
Add request opts to perform_request method args
d119abd
@estolfo
Update method template to handle create endpoint forwarding to index
8b0c185
@estolfo
Add unit test for perform request args
d11af8b
@estolfo
Update elasticsearch unit tests for additional perform_request arg
11f02e5
@estolfo
Update cat specs
a63af83
@estolfo
Update cluster specs
d7f1d5b
@estolfo
Update dangling_indices specs
b25a90c
@estolfo
Update data_frame specs
7776328
@estolfo
Update features specs
670e566
@estolfo
Update fleet specs
782dfb9
@estolfo
Update index_lifecycle_management specs
8a01b4d
@estolfo
Update indices specs
25c7f86
@estolfo
Update ingest specs
09e40f5
@estolfo
Update machine_learning specs
1599f1b
@estolfo
Update migration specs
4d2e368
@estolfo
Update info specs
94da052
@estolfo
Update query_ruleset specs
aea3f4e
@estolfo
Update search_application specs
b411561
@estolfo
Update searchable_snapshots specs
69ee0e1
@estolfo
Update security specs
f54f98e
@estolfo
Update shutdown specs
ef5c561
@estolfo
Update snapshot specs
bb04fc6
@estolfo
Update sql specs
03fb742
@estolfo
Update tasks specs
cf13de2
@estolfo estolfo requested a review from szabosteve September 26, 2023 19:42
estolfo
estolfo commented Sep 26, 2023
View reviewed changes
szabosteve
szabosteve approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this up! I left some smaller suggestions, please take or leave them. Documentation changes LGTM!

@estolfo
Minor docs updates
bb7b612 
Update docs/open-telemetry.asciidoc

Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co>

Update docs/open-telemetry.asciidoc

Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co>

Update docs/open-telemetry.asciidoc

Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co>

Update docs/open-telemetry.asciidoc

Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co>

Update docs/open-telemetry.asciidoc

Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co>

Update docs/open-telemetry.asciidoc

Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co>

Update docs/open-telemetry.asciidoc

Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co>

Update docs/open-telemetry.asciidoc

Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co>

Update docs/open-telemetry.asciidoc

Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co>

Update docs/open-telemetry.asciidoc

Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co>

Update docs/open-telemetry.asciidoc

Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co>

Update docs/open-telemetry.asciidoc

Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co>

Update docs/open-telemetry.asciidoc

Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co>

Minor change to docs
@estolfo
Remove special handling for create and just use index endpoint
938b196
@estolfo
Remove opts from args when calling perform_request directly
e7b0edd
@estolfo
Transport object is the http adapter so expected args don't change
2633e80
@estolfo
Only remove the last arg if it has an endpoint key
06f85d2
@estolfo
Temporarily disable unit tests
b05036a
@estolfo
download artifacts for unit tests
d994178
@estolfo
endpoint for creating a doc is index
28cbc84
@estolfo
download_artifacts rake task is in root
19676df
@estolfo
Further updates to create document spec
527a74c
@estolfo
Document client option opentelemetry_tracer_provider
e6e9e59
@estolfo
Put OpenTelemetry::TracerProvider in quotes
10aafe6
@estolfo
Inline documentation
77e2dd2
@estolfo
Require >= 8.3 of elastic-transport
66707fa
@estolfo
Add example of providing tracer provider to Client#new in the docs
55c8651
@picandocodigo picandocodigo merged commit 8b1c51d into elastic:main Sep 29, 2023
@pquentin pquentin mentioned this pull request Feb 12, 2024
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picandocodigo picandocodigo picandocodigo approved these changes

@szabosteve szabosteve szabosteve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estolfo @picandocodigo @szabosteve