Skip to content

OTel instrumentation: Add path patterns and endpoint in opts to perform_request #2131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

OTel instrumentation: Add path patterns and endpoint in opts to perform_request #2131

wants to merge 5 commits into from

Conversation

estolfo
Copy link
Contributor

@estolfo estolfo commented Jun 28, 2023

This PR complements a PR in the transport client

This PR does the following:

  • Adds the path patterns and endpoint id to the perform_request args list so that the transport client can use the values for the OpenTelemetry instrumentation
  • Updates all the endpoint methods with the new method signature

ToDo

  • Manually update the tests 😅
  • Maybe regenerate the code because there is a 8.10 reference in the generated doc link

@estolfo estolfo mentioned this pull request Jun 28, 2023
Merged
8 tasks
@estolfo estolfo changed the title OTel instrumentation: Add path patterns and endpoint as args to perform_request OTel instrumentation: Add path patterns and endpoint in opts to perform_request Jul 4, 2023
@estolfo estolfo mentioned this pull request Jul 24, 2023
Merged
@estolfo
Copy link
Contributor Author

estolfo commented Aug 25, 2023

Replaced by #2179

@estolfo estolfo closed this Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@estolfo