Skip to content

Check for invalid characters in X-Opaque-ID headers #1873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 20, 2022

Conversation

masseyke
Copy link
Member

This commit strips out any non-visible, non-ascii characters from the X-Opaque-ID header.
Closes #1872

@masseyke masseyke requested a review from jbaiera January 19, 2022 22:52
@masseyke masseyke changed the title Fix/x opaque id newlines Check for invalid characters in X-Opaque-ID headers Jan 19, 2022
Copy link
Member

@jbaiera jbaiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masseyke masseyke merged commit c7bdb67 into elastic:master Jan 20, 2022
@masseyke masseyke deleted the fix/x-opaque-id-newlines branch January 20, 2022 00:09
masseyke added a commit to masseyke/elasticsearch-hadoop that referenced this pull request Jan 20, 2022
This commit strips out any non-visible, non-ascii characters from the X-Opaque-ID header.
Closes elastic#1872
masseyke added a commit to masseyke/elasticsearch-hadoop that referenced this pull request Jan 20, 2022
This commit strips out any non-visible, non-ascii characters from the X-Opaque-ID header.
Closes elastic#1872
masseyke added a commit that referenced this pull request Jan 20, 2022
This commit strips out any non-visible, non-ascii characters from the X-Opaque-ID header.
Closes #1872
masseyke added a commit that referenced this pull request Jan 20, 2022
This commit strips out any non-visible, non-ascii characters from the X-Opaque-ID header.
Closes #1872
@masseyke masseyke added the :Rest label Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

X-Opaque-ID header can cause "No colon found" in Hive
2 participants