Update to edition-arica of the Eiffel protocol #68
Conversation
t-persson
requested review from
fredjn and
magnusbaeck
and removed request for
a team
|
I'll try to break out the workflow changes and create a separate PR for those (including fixing the warnings and errors) during the day or tomorrow |
There was a problem hiding this comment.
You need to update the link types table too, right? RUNTIME_ENVIRONMENT and PRECURSOR are missing (maybe more).
src/eiffel_graphql_api/graphql/schemas/events/json_schemas/EiffelActivityStartedEvent.json
Show resolved
Hide resolved
t-persson
force-pushed
the
update-to-arica
branch
from
eda8ea0 to
8f28249
Compare
docs/requirements.txt
Outdated
| @@ -1,4 +1,5 @@ | |||
| sphinx<2 | |||
| pyscaffold==2.5.10 | |||
| mistune==0.8.4 | |||
There was a problem hiding this comment.
Where and how is this dependency used?
There was a problem hiding this comment.
It is used by m2r (the line below) and m2r does not set version and the project is set to read-only. This meant that m2r wanted to install a version of mistune that was not backwards compatible thus breaking m2r for us.
There was a problem hiding this comment.
I want to remove m2r when we are updating to support newer python versions
t-persson
force-pushed
the
update-to-arica
branch
from
76d5220 to
fe6e26e
Compare
|
Added a commit with |
|
Still LGTM :-) |
Applicable Issues
fixes: #67
Description of the Change
Updated to the latest schemas
Alternate Designs
N/A
Benefits
N/A
Possible Drawbacks
N/A
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Tobias Persson tobias.persson@axis.com