Skip to content

Replace dataframe_from_dict with dataframe_from_columns #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2023
Merged

Replace dataframe_from_dict with dataframe_from_columns #276

merged 2 commits into from
Oct 24, 2023

Conversation

MarcoGorelli
Copy link
Contributor

Columns have names, so dataframe_from_dict isn't really necessary

drive-by: removing api_version from the functions in the Namespace protocol, which I should've done in #264

@MarcoGorelli MarcoGorelli force-pushed the dataframe-from-sequence branch 4 times, most recently from 1b9cc4f to 3fd9f30 Compare October 7, 2023 13:17
@MarcoGorelli MarcoGorelli marked this pull request as draft October 24, 2023 13:09
@MarcoGorelli MarcoGorelli marked this pull request as ready for review October 24, 2023 15:54
@MarcoGorelli MarcoGorelli changed the title Replace dataframe_from_dict with dataframe_from_sequence Replace dataframe_from_dict with dataframe_from_columns Oct 24, 2023
@MarcoGorelli
Copy link
Contributor Author

thanks for your review!

@MarcoGorelli MarcoGorelli merged commit 78c8e5d into data-apis:main Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkraus14 kkraus14 kkraus14 approved these changes

Assignees
No one assigned
Labels
API design
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcoGorelli @kkraus14