Skip to content

remove some unnecessary api_version args #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MarcoGorelli
Copy link
Contributor

@MarcoGorelli MarcoGorelli commented Sep 27, 2023

These are unnessary, as the namespace will already have been instantiated to follow a given api version

e.g.

df, xp = df.__dataframe_consortium_standard__(api_version='2023.09-beta')
# xp is already the 2023.09-beta API version
# so xp.dataframe_from_dict returns a dataframe compliant with the 2023.09-beta version

@MarcoGorelli
Copy link
Contributor Author

approved on today's call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant