Add an is_dtype function
#199
Conversation
| ---------- | ||
| dtype: Any | ||
| The input dtype. | ||
| kind: str |
There was a problem hiding this comment.
the array api also allows dtype, but I don't think we need that here. If you want to check whether a dtype is of a specific dtype, you can just use isinstance, e.g.
isinstance(column.dtype, namespace.Float64)I think this function is more useful for checking conceptual hierarchies, like 'integral'
So, for now, I'm only allowing str | tuple[str, ...]
There was a problem hiding this comment.
Part of the reason for allowing dtype instances is to allow arbitrary composition of dtype sets beyond the supported kinds and allow an escape hatch beyond the kinds officially supported by the array API standard.
There was a problem hiding this comment.
can't you do that with
is_dtype(column.dtype, 'integral') or isinstance(column.dtype, MyFancyDType)?
There was a problem hiding this comment.
Yes, but that becomes a bit unwieldy quickly if you want to arbitrarily combine multiple "kinds" and/or individual dtypes.
There was a problem hiding this comment.
I'd suggest keeping this simple to begin with, we can always increase complexity later if necessary
There was a problem hiding this comment.
I'd have made the same comment as @kgryte, I think it'll be needed and is better than using isinstance. However, it's a fully backwards-compatible extension, so I'm fine with leaving this comment unresolved here and a follow-up PR to extend the functionality to:
kind: str | tuple[str, ...] | DType | tuple[DType, ..]
|
Somehow |
There was a problem hiding this comment.
LGTM to merge - it's not complete, as discussed in the open comment thread, but this works as is and the rest can be done later.
Thanks @MarcoGorelli and @kgryte
| ---------- | ||
| dtype: Any | ||
| The input dtype. | ||
| kind: str |
There was a problem hiding this comment.
I'd have made the same comment as @kgryte, I think it'll be needed and is better than using isinstance. However, it's a fully backwards-compatible extension, so I'm fine with leaving this comment unresolved here and a follow-up PR to extend the functionality to:
kind: str | tuple[str, ...] | DType | tuple[DType, ..]
No description provided.