Skip to content

Filter zero division examples for test_remainder #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 5, 2022
Merged

Filter zero division examples for test_remainder #58

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f76a75c
Filter 0div int examples out for `test_remainder`
honno Jan 5, 2022
8930c3b
Remove faulty `test_remainder` test logic
honno Jan 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions xptests/test_elementwise_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1297,17 +1297,19 @@ def test_remainder(
):
left = data.draw(left_strat, label=left_sym)
right = data.draw(right_strat, label=right_sym)
# TODO: rework same sign testing below to remove this
if not right_is_scalar:
assume(len(left.shape) <= len(right.shape))
if right_is_scalar:
out_dtype = left.dtype
else:
out_dtype = dh.result_type(left.dtype, right.dtype)
if dh.is_int_dtype(out_dtype):
if right_is_scalar:
assume(right != 0)
else:
assume(not ah.any(right == 0))

res = func(left, right)
func(left, right)

if not right_is_scalar:
# res and x2 should have the same sign.
# ah.assert_same_sign returns False for nans
not_nan = ah.logical_not(ah.logical_or(ah.isnan(res), ah.isnan(left)))
ah.assert_same_sign(res[not_nan], right[not_nan])
# TODO: test results


@given(xps.arrays(dtype=xps.numeric_dtypes(), shape=hh.shapes()))
Expand Down