Skip to content

Filter zero division examples for test_remainder #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 5, 2022

Conversation

honno
Copy link
Member

@honno honno commented Jan 5, 2022

For integers, zero division is out-of-scope. cc @pmeier

@honno honno marked this pull request as draft January 5, 2022 11:49
@honno
Copy link
Member Author

honno commented Jan 5, 2022

There's another bug with the not_nan mask I see, must of been there for awhile. It also didn't check if the out array had a float dtype. Generally I think more can be done to test the output of remainder (I guess this was left alone as remainder behaviour was ambiguous at the time), but for now I'll leave it all out so at least we have a working smoke test.

@honno honno marked this pull request as ready for review January 5, 2022 12:01
@honno honno merged commit b08b33f into data-apis:master Jan 5, 2022
@honno honno deleted the remainder-0div branch February 8, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant