refactor: misc cleanup

[vicb]

No description provided.

[jbdeboer]

This PR fails in a large number of apps because: Type 'Profiler' not found in generated typeFactory maps. Is the type's constructor injectable and annotated for injection?

Please add a test that would catch this error and then fix it.

[vicb]

@jbdeboer good catch, Profiler is fom the perf_api package hence not marked a injectable. I've reverted this to a toFactory type.

I think the test belongs to the DI rather than angular. I once submitted a PR for that which did not get merged. I'll update this PR to work with the new DI.

(edit: the PR has been updated and should be ok now)

[jbdeboer]

No, there should a test in Angular that catches this -- it is odd that the e2e tests did not and that requires investigation.

[vicb]

@jbdeboer may be we can merge this and create an issue ?

[vicb]

Actually the Profiler is used only for Animations and they are disabled for e2e IIRC.

[jbdeboer]

Could we create an e2e test that triggered this error?

I would prefer to fix this gap in our test coverage now while we are focused on it instead of filing an issue that might not be fixed.

[vicb]

@chirayuk knows why anims have to be disabled for e2e, I don't. (and I fail to see how not merging this PR would help)

[vicb]

@jbdeboer I really think the solution (or part of it if you wish) is to be fixed at the root (ie di level), I have a PR almost ready based on my previous work (dart-archive/di.dart#104) with the updates requested by Pavel. It still need to write tests before submitting it.

[vicb]

@jbdeboer PR submitted to the DI: dart-archive/di.dart#174

[jbdeboer]

Thank you @vicb