This repository was archived by the owner on Dec 6, 2017. It is now read-only.
feat(dynamic injector): enforce annotations with dynamic injector #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes dart-archive#58 Enforcing annotations on types injected via TypeProvider is a good practice to make sure that the code will not break when switching from a dynamic to a static injector.
| DynamicInjector({List<Module> modules, | ||
| String name, | ||
| bool allowImplicitInjection: false, | ||
| Iterable<Type> assertAnnotations: null, |
There was a problem hiding this comment.
Not sure I like this... I'm thinking something along the lines of @Injectables...
@InjectableAnnotations(const [
MyInjectableAnnotation
])
library myapp;this way we can also make annotations parameter to generator/tramsformer optional.
|
We'll have to tackle this some other way in v2. Perhaps we should also reduce the number of ways to mark types as injectable to make this easier. |
This was referenced Aug 28, 2014
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #58
Enforcing annotations on types injected via TypeProvider is a good
practice to make sure that the code will not break when switching from a
dynamic to a static injector.