Skip to content

4.8.3 candidate #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

4.8.3 candidate #1457

wants to merge 16 commits into from

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented May 25, 2025

Description

Checklist

Code Changes

  • Add test cases to all the changes you introduce
  • Run poetry all locally to ensure this change passes linter check and tests
  • Manually test the changes:
    • Verify the feature/bug fix works as expected in real-world scenarios
    • Test edge cases and error conditions
    • Ensure backward compatibility is maintained
    • Document any manual testing steps performed
  • Update the documentation for the changes

Documentation Changes

  • Run poetry doc locally to ensure the documentation pages renders correctly

Expected Behavior

Steps to Test This Pull Request

Additional Context

@Lee-W
Copy link
Member Author

Lee-W commented May 25, 2025

Hey @woile @noirbizarre , I'd like to merge this one in the next few days. It contains all the PRs I reviewed this days to avoid bumping version too quickly

@Lee-W Lee-W changed the title Refactors 4.8.3 candidate May 25, 2025
Copy link

codecov bot commented May 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.78%. Comparing base (120d514) to head (856ca4f).
Report is 626 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1457      +/-   ##
==========================================
+ Coverage   97.33%   97.78%   +0.44%     
==========================================
  Files          42       57      +15     
  Lines        2104     2620     +516     
==========================================
+ Hits         2048     2562     +514     
- Misses         56       58       +2     
Flag Coverage Δ
unittests 97.78% <100.00%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Lee-W
Copy link
Member Author

Lee-W commented May 25, 2025

@bearomorphism, please let us know if you want us to include anything in the next release. We'll try to review them

@bearomorphism
Copy link
Contributor

#1449

@bearomorphism
Copy link
Contributor

and probably #1453 which I'm fixing

@bearomorphism
Copy link
Contributor

and #1442
I'm resolving the conflict

@bearomorphism
Copy link
Contributor

#1428

@bearomorphism
Copy link
Contributor

Those are small PRs (<60 lines of code changes excluding tests). Thanks 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants