refactor(changelog): better typing, yield #1453
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1453 +/- ##
==========================================
+ Coverage 97.33% 97.62% +0.28%
==========================================
Files 42 57 +15
Lines 2104 2649 +545
==========================================
+ Hits 2048 2586 +538
- Misses 56 63 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bearomorphism
force-pushed
the
refactor-changelog-4
branch
2 times, most recently
from
a210a28 to
982859d
Compare
bearomorphism
force-pushed
the
refactor-changelog-4
branch
from
982859d to
42a86cc
Compare
bearomorphism
commented
May 24, 2025
|
|
||
|
|
||
| def test_order_changelog_tree_raises(): | ||
| change_type_order = ["BREAKING CHANGE", "feat", "refactor", "feat"] | ||
| with pytest.raises(InvalidConfigurationError) as excinfo: | ||
| changelog.order_changelog_tree(COMMITS_TREE, change_type_order) | ||
| list(changelog.order_changelog_tree(COMMITS_TREE, change_type_order)) |
There was a problem hiding this comment.
Added list here for triggering the error.
bearomorphism
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Code Changes
poetry alllocally to ensure this change passes linter check and testsExpected Behavior
Steps to Test This Pull Request
Additional Context