Issue165: auth/login route not working #185
Conversation
|
Okay I will test the route with your code once @pragun22 if it's good their I will tell here. 😄 .If you have tested the route already then please tell . |
|
@TG1999 I have done some basic testing like just sending a request with headers through postman(screenshot is attached in the PR) and npm request, you can do deep testing of the route. |
|
Sounds good I will be doing by tonight
…On Wed 17 Apr, 2019, 13:52 Pragun, ***@***.***> wrote:
@TG1999 <https://github.com/TG1999> I have done some basic testing like
just sending a request with headers through postman(screenshot is attached
in the PR) and npm request, you can do deep testing of the route.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#185 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AglAILBsHec4nYc_ctnKX3O4ctz2x-dQks5vhtnMgaJpZM4czsrE>
.
|
|
@pragun22 , before anything else, please rename your PR and follow the best practices of PR naming. |
|
@prateekiiest thanks for the feedback, I have changed PR name. kindly check if it is alright. |
|
#185 (comment) |
prateekiiest
requested review from
jaskiratsingh2000,
pranjalkumar and
vaibhavdaren
|
@pragun22 please make different branch for solving different issues. |
|
why 3 commits ? |
|
@vaibhavdaren I may have mixed some branches(sorry for that), |
Issue165: auth/login route not working #185
Problem
data.compare was not working in login.routes.js
Issue this PR referred to
Fixes issue number #165 , Refer to this link for more details_
Solution of problem
Compare was not working as data received is in the form of struct and .compare does not work for them. So I replaced it with a "==" operator to compare passwords of both structs.
Before and After Screenshots
error/problem
output of request after solving the problem
Type of Change
Checklist