Skip to content

Issue165: auth/login route not working #185 #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2019

Conversation

pragun22
Copy link
Contributor

@pragun22 pragun22 commented May 3, 2019

Problem

data.compare was not working in login.routes.js

Issue this PR referred to

Fixes issue number #165 , Refer to this link for more details_

Solution of problem

Compare was not working as data received is in the form of struct and .compare does not work for them. So I replaced it with a "==" operator to compare passwords of both structs in the file login.routes.js.

Before and After Screenshots

error/problem

Screenshot from 2019-04-17 01-53-38

output of request after solving the problem

Screenshot from 2019-04-17 01-59-51

Screenshot from 2019-04-17 01-59-46

Type of Change

  • Small refactor

Checklist

  • My code follow the same style as the codebase
  • My Code changed required change in documentation
  • I have updated the Readme accordingly
  • I made PR within development branch only

@vaibhavdaren vaibhavdaren merged commit 0c84d1a into codeuino:development May 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants