Add option to simply enable TLS instead of providing certain config parameters, and also remove hardcoded rejectUnauthorized = false
#257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasShih
commented
May 27, 2025
| const socket = this.params.ssl | ||
| ? tls.connect(this.params.port, this.params.hostname, { | ||
| ...this.params.ssl, | ||
| rejectUnauthorized: false, |
There was a problem hiding this comment.
Any particular reason why this was hardcoded?
ThomasShih
commented
May 27, 2025
| ca: await readFile("./tls-gen/basic/result/ca_certificate.pem", "utf8"), | ||
| cert: await readFile(`./tls-gen/basic/result/client_${firstNode.host}_certificate.pem`, "utf8"), | ||
| key: await readFile(`./tls-gen/basic/result/client_${firstNode.host}_key.pem`, "utf8"), | ||
| rejectUnauthorized: true, |
There was a problem hiding this comment.
To recover previous behaviour, we can remove this!
ThomasShih
commented
May 27, 2025
Comment on lines
+767
to
+769
| enabled: true | ||
| endpoint?: { host: string; port: number } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests aren't working on my local before my changes and I haven't had a time to troubleshoot. Hopefully what exists in this PR can be a good jumping off point!