Issues with TLS Support

[ThomasShih]

• RejectUnauthorized is hardcoded to false
• No way of enabling TLS without passing in parameters

[ThomasShih]

Some thoughts include:

export interface SSLConnectionParams {
  key: string
  cert: string
  ca?: string
}

into

export type SSLConnectionParams = {
  enabled: true
  options?: {
    key: string
    cert: string
    ca?: string
    rejectUnauthorized?: boolean
  }
} | {
  enabled: false
}

---

and

---

private createSocket() {
    const socket = this.params.ssl
      ? tls.connect(this.params.port, this.params.hostname, {
          ...this.params.ssl,
          rejectUnauthorized: false,
        })
      : new Socket().connect(this.params.port, this.params.hostname)
    if (this.params.socketTimeout) socket.setTimeout(this.params.socketTimeout)
    return socket
  }

into

  private createSocket() {
    const sslEnabled = this.params.ssl !== undefined && this.params.ssl.enabled === true
    const socket = sslEnabled
      ? tls.connect(this.params.port, this.params.hostname, this.params.ssl.options)
      : new Socket().connect(this.params.port, this.params.hostname)
    if (this.params.socketTimeout) socket.setTimeout(this.params.socketTimeout)
    return socket
  }

I don't have permissions to push a branch of this in a PR, but hopefully these ideas might be of value!

[ThomasShih]

Opps, never done open source before, I will fork and push a PR sometime today!

[Gsantomaggio]

No problem @ThomasShih
Thank you

[ThomasShih]

#257