各DojoのリストをStaticで表示した #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
最初の2コミットはテスト用ライブラリ追加なのでプルリク分けたほうが見やすくなりそうな気がしました! |
yasulab
reviewed
Dec 10, 2016
| end | ||
|
|
||
| it "With coderdojo list" do | ||
| assert_select "p.ng-binding", count:54 |
There was a problem hiding this comment.
これは... Dojoを１つ増やすたびにテストコードを更新するということかな? 😅
There was a problem hiding this comment.
まぁこれはあとで直しましょう。とりあえずマージします ✅
#28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やりたいこと
ドメイン変更により、dojoのリストの表示ができなくなる可能性があるので、
静的ページで一時的なリストを作った。
今後はDBを作り、フォームから情報を取得し、動的にdojoの追加や削除ができるようなセクションにする予定
やること