Update index content #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanophate
force-pushed
the
update_index_content
branch
2 times, most recently
from
666a194 to
b38deae
Compare
nanophate
force-pushed
the
update_index_content
branch
from
b38deae to
fd7e3fb
Compare
|
良さそう! 😸 ✨ とりあえずマージしちゃいますね ;) あといつも言っているけど、今回もテストがないので、まずは「タイトルやフッターに "CoderDojo Japan" があるかどうか」みたいな簡単テストからでもいいので、テスト書きましょう💦 |
|
@nanophate とはいえ、トップページが復元できたので、12/11 (日曜) のドメイン切り替え ( #23 (comment) ) には余裕を持って間に合いそうで良かったです! 👍 ✨ あとはテストとインフラ周り (Heroku, Circle CI, ドメイン設定など) ですかね ;) |
まだ全国のCodorDojo の読み込みができていません。 来週中には直接データベースから取得できるようにします。 |
|
#26 で各dojoを静的に表示できるようにしました。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やりたいこと
CoderDojoのサイトを丸々表示できるようにする。
やること