Skip to content

Use eager_load instead of includes #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2017
Merged

Use eager_load instead of includes #207

merged 1 commit into from
Nov 23, 2017

Conversation

nalabjp
Copy link
Member

@nalabjp nalabjp commented Nov 23, 2017

fix #186 (comment)

5.1.4@2.4.2 (main)> Dojo.includes(:dojo_event_services).where(dojo_event_services: { name: :connpass }).to_sql == Dojo.eager_load(:dojo_event_services).where(dojo_event_services: { name: :connpass }).to_sql
=> true

@nalabjp
Use eager_load instead of includes
2fe1206 
```
5.1.4@2.4.2 (main)> Dojo.includes(:dojo_event_services).where(dojo_event_services: { name: :connpass }).to_sql == Dojo.eager_load(:dojo_event_services).where(dojo_event_services: { name: :connpass }).to_sql
=> true
```
@nalabjp nalabjp merged commit 3893067 into master Nov 23, 2017
@nalabjp nalabjp deleted the eager_load branch November 23, 2017 05:15
@nalabjp nalabjp mentioned this pull request Nov 26, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nalabjp