Fix N+1 #186
Merged
Fix N+1 #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM and passed the test suites! Thanks! 😸 |
|
おぉ、すばやい😁 |
hanachin
reviewed
Nov 21, 2017
| fsbk_dojos = Dojo.joins(:dojo_event_services).where(dojo_event_services: { name: :facebook }).to_a | ||
| cnps_dojos = Dojo.includes(:dojo_event_services).where(dojo_event_services: { name: :connpass }).to_a | ||
| drkp_dojos = Dojo.includes(:dojo_event_services).where(dojo_event_services: { name: :doorkeeper }).to_a | ||
| fsbk_dojos = Dojo.includes(:dojo_event_services).where(dojo_event_services: { name: :facebook }).to_a |
There was a problem hiding this comment.
CoderDojo規模だと問題なさそうですが、このへんincludesだとjoinされるかpreloadされるかわかりづらいので、includes使うのは辞めておいたほうがいいのかもしれません。
過激な意見:
includes を殺して preload か eager_load を強制する cop 転がってないかな
— Takafumi ONAKA (@onk) October 30, 2017
There was a problem hiding this comment.
なるほど、ありがとうございます。
直感的に分かるというのはその通りですね。
eager_loadを明示するようにしておきます！
yasulab
added
the
統計情報
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
N+1が出ていたので
joins->includesしました。