-
-
Notifications
You must be signed in to change notification settings - Fork 108
Rubyのバージョンを3.2.8にする #1684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Rubyのバージョンを3.2.8にする #1684
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d73dad7
Bump Ruby version to 3.2.8
kimihito 0aaeb06
Fix File.exists? to File.exist? for compatibility with Ruby 3.2
kimihito e8dcdf5
Change method name from exists? to exist? to match `File#exist?`
kimihito 98e490e
Dockerfile: update Ruby version from 3.1.6 to 3.2.8
kimihito File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
3.1.6 | ||
3.2.8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
source 'https://rubygems.org' | ||
ruby '3.1.6' | ||
ruby '3.2.8' | ||
|
||
gem 'bootsnap' | ||
gem 'pg' | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -567,7 +567,7 @@ DEPENDENCIES | |
web-console | ||
|
||
RUBY VERSION | ||
ruby 3.1.6p260 | ||
ruby 3.2.8p263 | ||
|
||
BUNDLED WITH | ||
2.5.19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
【気になっている】 今回は標準ライブラリの
File#exist?
だけを変更していますが、このメソッドもそちらに合わせた方がよいか迷っています。Document#exists?
なども定義しているので、Podcast#exists?
もそのままでよいかな?と判断したのですがフィードバックいただけると幸いです 🙏Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kimihito PR ありがとうございます!😻🆒✨
ダックタイピングしているものなので他のも合わせて
exist?
に変えてもらえると助かります!(>人< )✨There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yasulab e8dcdf5 で対応してみました!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
早速のご対応ありがとうございます!マージしますね...!! 😻🆒✨