Rubyのバージョンを3.2.8にする #1684
Merged
Rubyのバージョンを3.2.8にする #1684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimihito
commented
May 16, 2025
app/models/podcast.rb
Outdated
| @@ -21,7 +21,7 @@ def path | |||
| def exists?(offset: 0) | |||
There was a problem hiding this comment.
【気になっている】 今回は標準ライブラリの File#exist? だけを変更していますが、このメソッドもそちらに合わせた方がよいか迷っています。
Document#exists? なども定義しているので、Podcast#exists? もそのままでよいかな？と判断したのですがフィードバックいただけると幸いです 🙏
There was a problem hiding this comment.
@kimihito PR ありがとうございます！😻🆒✨
ダックタイピングしているものなので他のも合わせて exist? に変えてもらえると助かります！(＞人＜ )✨
There was a problem hiding this comment.
早速のご対応ありがとうございます！マージしますね...!! 😻🆒✨
kimihito
force-pushed
the
chore/bump-ruby-3.2.8
branch
from
61b286b to
e8dcdf5
Compare
8 tasks
This was referenced May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
対応Issue
#1683 の対応です
やったこと
表題の通り、Rubyのバージョンを3.1.6から3.2.8に変更しました。
close #1683