Skip to content

Many indentation improvements #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 10, 2015
Merged

Many indentation improvements #319

merged 5 commits into from
Sep 10, 2015

Conversation

Malabarba
Copy link
Member

No description provided.

@bbatsov
Copy link
Member

bbatsov commented Sep 10, 2015

Nice PR! Just add some tests here https://github.com/clojure-emacs/clojure-mode/blob/master/test/clojure-mode-indentation-test.el for every commit.

@Malabarba
[Fix #304] Indentation of forms with metadata specs
39a9ee3 
We were indenting like this
(ns ^:doc app.core
    (:gen-class))

Now we indent like this
(ns ^:doc app.core
  (:gen-class))
@Malabarba
[Fix #308 Fix #287 Fix #45] Corner-case indentation of multi-line sexps
4079913 
We were indenting like this
[[
  2] a
  x]

Now we indent like this
[[
  2] a
 x]
@Malabarba
[Fix #292] Indentation in reader conditionals
e8c71e1 
Before
 #?(:clj :foo
         :cljs :bar)
Now
 #?(:clj :foo
    :cljs :bar)
@Malabarba
Copy link
Member Author

All pushed, let's see if it passes.

@Malabarba
Copy link
Member Author

I'm not sure what's the matter here. The test is pretty simple and it passes for me locally.

@bbatsov
Copy link
Member

bbatsov commented Sep 10, 2015

Might be something to do with the Emacs version. The tests are running on 24.3 and I doubt you're using it yourself. The failing test itself looks simple enough, so I'm guessing the problem is in the indentation logic.

@Malabarba
Copy link
Member Author

Except it's failing on the snapshot build too. Or is that a mislabeled build?

@bbatsov
Copy link
Member

bbatsov commented Sep 10, 2015

Ancient snapshot - this repo hasn't been updated in years...

@bbatsov
Copy link
Member

bbatsov commented Sep 10, 2015

See https://launchpad.net/~cassou/+archive/ubuntu/emacs

@Malabarba
Copy link
Member Author

I see...
Hopefully I can reproduce it in 24.5. For some reason 24.3 is the only version I never managed to install with evm.

@Malabarba
Copy link
Member Author

OK, it was cl's fault. It's passing now.

bbatsov added a commit that referenced this pull request Sep 10, 2015
@bbatsov
Merge pull request #319 from Malabarba/master
ec312af 
Many indentation improvements
@bbatsov bbatsov merged commit ec312af into clojure-emacs:master Sep 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Malabarba @bbatsov @ptaoussanis @tgetgood @expez