Wrong let indentation

[Malabarba]

This is how clojure-mode indents the following form.

(let [{{{sha :sha} :head} :pull_request,
       {{user :login} :owner, :as repo} :repository} body
       base-analysis (something repo)]
  ...)

It's a pretty complicated destructuring, but the important point is that the indentation engine is indenting base-analysis as if it were part of the map above it, but it's really a whole new let-bind.

[bbatsov]

That's not an isolated case - pretty much every more complex scenario breaks the indentation as so much was originally copy/pasted or inherited from lisp-mode. Everything needs to be examined and re-engineered, but I don't see this happening any time soon.

[bbatsov]

See also #45 and #270

[Malabarba]

It's not a huge deal anyway. :)

[bbatsov]

Yeah, I guess. Still, sooner or later we need to clean up the indentation mess. Like CIDER, clojure-mode was put together rather quickly and still carries quite the legacy around. But on the positive side, we're always making progress, albeit a bit slowly.

[Malabarba]

Yeah, I tried to write an indent-line function for ahk scripts a couple of years ago and I know how nasty they can be.