Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Dev/use extend #72

Closed
wants to merge 47 commits into from
Closed

Dev/use extend #72

wants to merge 47 commits into from

Conversation

codebender828
Copy link
Collaborator

Composes components using the extend API.

This is to make composition easier and help save a few KB in final build.

How Has This Been Tested?

View storybook and unit test changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codebender828
refactor(pseudobox): use extend for composition
d236321
@codebender828
refactor(alert): use extend for composition
c48cddc
@codebender828
refactor(alertdialog): use extend for composition
29722d6
@codebender828
refactor(aspectratiobox): use extend for composition
4359786
@codebender828
refactor(avatar): use extend for composition
c173b4d
@codebender828
refactor(avatargroup): useextend for composition and fix prop forwarding
31443fe
@codebender828
refactor(breadcrumb): use extend for composition
50f8e3c
@codebender828
refactor(button): use extend for composition
a6a04c9
@codebender828
refactor(buttongrou): use extend for composition
05a0568
@codebender828
refactor(checkbox): use extend for composition
0776861
@codebender828
refactor(checkboxgroup): use extend for composition
b7bcbe0
@codebender828
refactor(circularprogress): use extend for composition
1b6229b
@codebender828
refactor(closebutton): use extend for composition
fa945c9
@codebender828
refactor(code): use extend for composition
94a622e
@codebender828
refactor(drawer): use extend for composition
66c1f67
@codebender828
refactor(flex): use extend for composition
e43fd50
@codebender828
refactor(formcontrol): use extend for composition
3767222
@codebender828
refactor(formhelpertext): use extend for composition
14e59fa
@codebender828
refactor(formlabel): use extend for composition
e1c21f6
@codebender828
refactor(icon): use extend for composition
632a6ce
@codebender828
refactor(iconbutton): use extend for composition
8aa14aa
@codebender828
refactor(image): use extend for composition
e418e46
@codebender828
refactor(list): use extend for composition
dede4df
@codebender828
refactor(listitems): use extend for composition
2af4725
@codebender828
refactor(menu): use extend for composition
069cb10
@codebender828
refactor(modal): use extend for composition
a2adc95
@codebender828
refactor(numberinput): use extend for composition
e8229bf
@codebender828
refactor(popover): use extend for composition
3282eea
@codebender828
improvement(popover): debug close on clickaway
0e04171
@codebender828
refactor(progress): use extend for composition
b105a9a
codebender828
codebender828 commented Mar 24, 2020
View reviewed changes
Copy link
Collaborator Author

@codebender828 codebender828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koca Modified a few snapshot test files. I thought you might be interested in seeing this before I merge.

@codebender828 codebender828 requested a review from koca March 24, 2020 13:01
koca
koca approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@koca koca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Menu doesn't work. Other than that feels cleaner. In terms of performance and benefits im not sure. But seems ok.

@codebender828 codebender828 added status: work in progress 🐜 Someone is working on this topic: component API 🔭 Related with the API of a given component labels Mar 25, 2020
@codebender828
Copy link
Collaborator Author

Closing this in favour of #245

@codebender828 codebender828 deleted the dev/use-extend branch July 25, 2020 18:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@koca koca koca approved these changes

Assignees

@codebender828 codebender828

Labels
status: work in progress 🐜 Someone is working on this topic: component API 🔭 Related with the API of a given component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebender828 @koca