This repository was archived by the owner on Sep 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 139
Performance: Use $attrs to manage styles #245
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-vue/inz8oot5n |
…hakra-ui/chakra-ui-vue into refactor/primitive-performance
koca
reviewed
Jul 14, 2020
koca
reviewed
Jul 14, 2020
koca
reviewed
Jul 14, 2020
koca
reviewed
Jul 14, 2020
koca
reviewed
Jul 14, 2020
koca
reviewed
Jul 14, 2020
koca
reviewed
Jul 14, 2020
koca
reviewed
Jul 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance: Use $attrs to manage styles
Closes #241
Description
This pull request seeks to provide an improvement in performance in the component primitives.
After doing some investigation here, and a large portion of the performance expense has to do with how the Chakra primitives are managing their props. Because of the props architecture with Vue, quite a lot of logic runs in between merging of consumer + default props.
To improve performance we sought to use the component
$attrs
as opposed to props resolution.View demo:
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: