Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Fix CTextarea not working with v-model #549

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Fix CTextarea not working with v-model #549

merged 1 commit into from
Jan 23, 2023

Conversation

JackuB
Copy link
Contributor

@JackuB JackuB commented Nov 9, 2022

Description

I ran into a same issue as #548
Verified that their proposed fix indeed works and added a minimal test case.

Fixes #548

Related to changes in #543 - like removing the inputValue: String, prop.

Motivation and Context

Screenshots (if appropriate):

I copied and adapted test suite from CInput, and the v-model test failed before the change.

Screenshot 2022-11-09 at 1 38 26

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@changeset-bot
Copy link

changeset-bot bot commented Nov 9, 2022

⚠️ No Changeset found

Latest commit: 7b0aede

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
chakra-ui-vue ✅ Ready (Inspect) Visit Preview Nov 9, 2022 at 0:52AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 9, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7b0aede:

Sandbox Source
Chakra UI Vue (0.X) Starter Template Configuration
chakra-ui-nuxt-demo Configuration

Copy link
Collaborator

@codebender828 codebender828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @JackuB

@codebender828 codebender828 merged commit 42eda9f into chakra-ui:develop Jan 23, 2023
@JackuB JackuB deleted the fix/ctextarea-v-model branch January 30, 2023 09:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CTextarea's v-model binds to the wrong prop
2 participants