Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

fix: Not working props in CTextarea #543

Merged
merged 5 commits into from
Mar 24, 2023

Conversation

oshima-gangan
Copy link
Contributor

Description

I found that the CTextarea props weren't working. Fixed props to work.

Motivation and Context

Cannot change py, minHeight, fontFamily, lineHeight due to props not working.

How Has This Been Tested?

Ran Storybook with the changes and viewed various stories.

Screenshots (if appropriate):

default
image

py
image

fontFamily
image

lineHeight
image

minHeight
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2022

⚠️ No Changeset found

Latest commit: 5713362

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
chakra-ui-vue ✅ Ready (Inspect) Visit Preview Nov 5, 2022 at 9:18PM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 1, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5713362:

Sandbox Source
Chakra UI Vue (0.X) Starter Template Configuration
chakra-ui-nuxt-demo Configuration

@codebender828 codebender828 merged commit 7a81035 into chakra-ui:develop Mar 24, 2023
@codebender828
Copy link
Collaborator

Thank you @oshima-gangan

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants