Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

fix: alert dialog leastDestructiveRef prop type #547

Merged
merged 2 commits into from
Jan 23, 2023
Merged

fix: alert dialog leastDestructiveRef prop type #547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89fd2a2
fix: alert dialog `leastDestructiveRef` prop type
Cynthiafan Oct 11, 2022
bf3b6d4
Merge branch 'develop' into fix/alert_dialog_leastDestructiveRef_type
codebender828 Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/chakra-ui-core/src/CAlertDialog/CAlertDialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ const CAlertDialog = {
type: Function,
default: () => null
},
leastDestructiveRef: [HTMLElement, Object]
leastDestructiveRef: [HTMLElement, Object, String, Function]
},
render (h, { slots, props, data }) {
return h(CModal, {
Expand Down
2 changes: 1 addition & 1 deletion website/pages/alertdialog.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,4 +120,4 @@ exception is that it requires a `leastDestructiveRef` which is similar to the

| Name | Type | Default | Description |
| ------------------------------ | --------------------------------- | ------- | ------------------------------------------------------------- |
| leastDestructiveRef (required) | `ref`, `selector` `Function: ref` | | The least destructive action to get focus when dialog is open |
| leastDestructiveRef (required) | `vm.$ref`, `() => vm.ref` or `CSS selector` | | The least destructive action to get focus when dialog is open |