This repository was archived by the owner on Sep 20, 2024. It is now read-only.
fix: alert dialog leastDestructiveRef
prop type
#547
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
AlertDialog
component's prop leastDustructiveRef should accept the same type as theModal
component's prop initialFocusRef.Motivation and Context
When I pass a function that returns a ref to leastDustructiveRef, it works well but shows a prop type warning.
How Has This Been Tested?
Ran Storybook with the changes and viewed various stories.
Types of changes
Checklist: