-
Notifications
You must be signed in to change notification settings - Fork 274
chore: bump React Native to 0.64 RC #626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
a04d35a
chore: bump React Native to 0.64 RC
0f927e3
Snapshot update
8971dbf
Bumped node version to 12 on CI
cae32ac
Removed removed supress_comment syntax from config
6002217
codemod types-first
880388c
Prettied files after codemod
baadffc
Added flow types to API returns
74d94ca
don't return null from fireEvent handlers
thymikee 5907f96
return ReactTestInstance instead of any
thymikee 02d1188
fix render returning any
thymikee f4c4fc8
less anys
thymikee a04ad1e
less anys
thymikee 7ae15f2
simplify call type
thymikee b21bd32
simplify
thymikee aac8793
add Flow to missing files, type debug better
thymikee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,9 @@ | ||
// @flow | ||
import { act } from 'react-test-renderer'; | ||
import type { Thenable } from './types.flow'; | ||
|
||
const actMock = (callback: () => void) => { | ||
callback(); | ||
}; | ||
|
||
export default act || actMock; | ||
export default (act || actMock: (callback: () => void) => Thenable); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,11 +6,11 @@ import makeQuery from './makeQuery'; | |
type GetReturn = ReactTestInstance; | ||
type GetAllReturn = Array<ReactTestInstance>; | ||
type QueryReturn = ReactTestInstance | null; | ||
type QueryAllReturn = Array<ReactTestInstance> | []; | ||
type QueryAllReturn = Array<ReactTestInstance>; | ||
type FindReturn = Promise<GetReturn>; | ||
type FindAllReturn = Promise<GetAllReturn>; | ||
|
||
type A11yAPI = {| | ||
export type A11yAPI = {| | ||
// Label | ||
getByA11yLabel: (string | RegExp) => GetReturn, | ||
getByLabelText: (string | RegExp) => GetReturn, | ||
|
@@ -116,7 +116,7 @@ export function matchObject<T: {}>(prop?: T, matcher: T): boolean { | |
: false; | ||
} | ||
|
||
const a11yAPI = (instance: ReactTestInstance): A11yAPI => | ||
export const a11yAPI = (instance: ReactTestInstance): A11yAPI => | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. changed to be consistent with other queries |
||
({ | ||
...makeQuery( | ||
'accessibilityLabel', | ||
|
@@ -239,5 +239,3 @@ const a11yAPI = (instance: ReactTestInstance): A11yAPI => | |
matchObject | ||
)(instance), | ||
}: any); | ||
|
||
export default a11yAPI; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the
[]
fallback, as Flow treats it as a tuple and thinks that the array has no elements. Which may be true, but would require users to optional-chain a lot