chore: bump React Native to 0.64 RC #626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a rebase |
suezzo
commented
Dec 9, 2020
thymikee
reviewed
Dec 9, 2020
| @@ -6,11 +6,11 @@ import makeQuery from './makeQuery'; | |||
| type GetReturn = ReactTestInstance; | |||
| type GetAllReturn = Array<ReactTestInstance>; | |||
| type QueryReturn = ReactTestInstance | null; | |||
| type QueryAllReturn = Array<ReactTestInstance> | []; | |||
There was a problem hiding this comment.
Removed the [] fallback, as Flow treats it as a tuple and thinks that the array has no elements. Which may be true, but would require users to optional-chain a lot
thymikee
reviewed
Dec 9, 2020
| @@ -116,7 +116,7 @@ export function matchObject<T: {}>(prop?: T, matcher: T): boolean { | |||
| : false; | |||
| } | |||
|
|
|||
| const a11yAPI = (instance: ReactTestInstance): A11yAPI => | |||
| export const a11yAPI = (instance: ReactTestInstance): A11yAPI => | |||
There was a problem hiding this comment.
changed to be consistent with other queries
thymikee
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Making sure we're compatible with the latest upcoming RN and Flow versions.
Test plan
CI